fix(framework-examples): fix Aurelia example (#120) #126

Thanood · 2016-12-17T16:13:18Z

should fix #120

upstream update

traviskaufman

Thanks for your work on this @Thanood! Changes requested are mostly nits.

traviskaufman · 2016-12-19T15:58:23Z

framework-examples/aurelia/.editorconfig

+# 2 space indentation
+[**.*]
+indent_style = space
+indent_size = 2


nit: newline at EOF

I hope this file is okay now, although GitHub issue tracker doesn't seem to recognize the newline I put in, it's there in my editor (and in GitHub's editor).

traviskaufman · 2016-12-19T15:58:50Z

framework-examples/aurelia/.vscode/settings.json

@@ -0,0 +1,4 @@
+// Place your settings in this file to overwrite default and user settings.


is this valid JSON?

Well no, of course not. :)
It's what vscode puts in this file, sorry.

np as long as whatever is using it can parse it, it's cool by me

traviskaufman · 2016-12-19T15:59:01Z

framework-examples/aurelia/custom_typings/fetch.d.ts

@@ -2,4 +2,4 @@
 interface URLSearchParams {}
 declare module "isomorphic-fetch" {
  export = fetch;
-}
+}


nit: newline at EOF

is this newline taken care of as well?

Yes, it is. No idea why it doesn't show up.

traviskaufman · 2016-12-19T16:02:35Z

framework-examples/aurelia/package.json

-  "aurelia": {
-    "build": {
-      "resources": []
+    "repository": {


I think we should add "private": true here, as well as remove keywords, author, license, contributors, bugs, and homepage keys.

Agreed. Is the repository field okay?

Ah yeah I'd take that out as well. Pretty much anything that has to do with the Aurelia Skeleton, since it doesn't help convey the fact that this is an MDC-Web example.

traviskaufman · 2016-12-19T16:10:48Z

framework-examples/aurelia/src/components/button/mdc-button.ts

@@ -1,8 +1,10 @@
 import {bindable, customAttribute, inject, DOM} from 'aurelia-framework';

 // Use webpack's require function to load the css
-const MDC_BUTTON_STYLES = require('mdc-button-styles');
-DOM.injectStyles(MDC_BUTTON_STYLES);
+// const MDC_BUTTON_STYLES = require('mdc-button-styles');


remove commented-out code?

traviskaufman · 2016-12-19T16:10:56Z

framework-examples/aurelia/src/components/button/mdc-button.ts

+// const MDC_BUTTON_STYLES = require('mdc-button-styles');
+import '@material/button/dist/mdc.button.css';
+
+// DOM.injectStyles(MDC_BUTTON_STYLES);


remove commented-out code?

traviskaufman · 2016-12-19T16:11:05Z

framework-examples/aurelia/src/components/button/mdc-button.ts

@@ -1,8 +1,10 @@
 import {bindable, customAttribute, inject, DOM} from 'aurelia-framework';

 // Use webpack's require function to load the css


is this comment still relevant?

traviskaufman · 2016-12-19T16:11:45Z

framework-examples/aurelia/src/components/checkbox/mdc-checkbox.ts

@@ -2,10 +2,13 @@ import {inject, bindable, bindingMode, DOM} from 'aurelia-framework';

 // Since we don't have typings (yet) we require mdc-checkbox manually.
 // const MDCCheckboxModule = require('mdc-checkbox');
-const {MDCCheckbox} = require('mdc-checkbox');
+// const {MDCCheckbox} = require('mdc-checkbox');


remove commented-out code?

traviskaufman · 2016-12-19T16:11:54Z

framework-examples/aurelia/src/components/checkbox/mdc-checkbox.ts

-const {MDCCheckbox} = require('mdc-checkbox');
+// const {MDCCheckbox} = require('mdc-checkbox');
+import {MDCCheckbox} from '@material/checkbox';
+
 // Use webpack's require function to load the css


is this comment still relevant?

traviskaufman · 2016-12-19T16:12:13Z

framework-examples/aurelia/src/components/ripple/mdc-ripple.ts

@@ -2,10 +2,13 @@ import {bindable, customAttribute, inject, DOM} from 'aurelia-framework';

 // Since we don't have typings (yet) we require mdc-ripple manually.


Same comments as above regarding stale doc comments and commented-out code

Thanood · 2016-12-19T18:56:18Z

Thanks, @traviskaufman.
Changes applied.

traviskaufman

LGTM, just one comment regarding package.json. Once that's fixed, good to merge.

traviskaufman · 2016-12-19T20:33:09Z

framework-examples/aurelia/package.json

-  "aurelia": {
-    "build": {
-      "resources": []
+    "repository": {


Ah yeah I'd take that out as well. Pretty much anything that has to do with the Aurelia Skeleton, since it doesn't help convey the fact that this is an MDC-Web example.

traviskaufman · 2016-12-19T20:34:11Z

framework-examples/aurelia/.vscode/settings.json

@@ -0,0 +1,4 @@
+// Place your settings in this file to overwrite default and user settings.


np as long as whatever is using it can parse it, it's cool by me

traviskaufman · 2016-12-19T20:34:26Z

framework-examples/aurelia/custom_typings/fetch.d.ts

@@ -2,4 +2,4 @@
 interface URLSearchParams {}
 declare module "isomorphic-fetch" {
  export = fetch;
-}
+}


is this newline taken care of as well?

Thanood · 2016-12-19T23:09:40Z

Removed repo from package.json. 😃

traviskaufman · 2016-12-20T15:41:46Z

Thanks as always @Thanood 👍

Thanood added 3 commits December 17, 2016 17:09

Merge pull request #1 from material-components/master

f227a87

upstream update

fix(framework-examples): fix Aurelia example (material-components#120)

96a59a8

chore(framework-examples): update Aurelia example README

76312fd

traviskaufman suggested changes Dec 19, 2016

View reviewed changes

chore(framework-examples): remove nitpicks from Aurelia sample

c8297fa

traviskaufman approved these changes Dec 19, 2016

View reviewed changes

chore(framework-examples): remove repository field from Aurelia sample

896f913

Merge branch 'master' into master

dd2e811

traviskaufman merged commit 71f6162 into material-components:master Dec 20, 2016

snyk-bot mentioned this pull request Jul 18, 2021

[Snyk] Upgrade tslib from 1.9.3 to 1.14.1 hackhit/material-components-web#1

Open

AceMentura mentioned this pull request Oct 18, 2022

[Snyk] Upgrade tslib from 1.9.3 to 1.14.1 AceMentura/material-components-web#79

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(framework-examples): fix Aurelia example (#120) #126

fix(framework-examples): fix Aurelia example (#120) #126

Thanood commented Dec 17, 2016

traviskaufman left a comment

traviskaufman Dec 19, 2016

Thanood Dec 19, 2016

traviskaufman Dec 19, 2016

Thanood Dec 19, 2016

traviskaufman Dec 19, 2016

traviskaufman Dec 19, 2016

traviskaufman Dec 19, 2016

Thanood Dec 19, 2016

traviskaufman Dec 19, 2016

Thanood Dec 19, 2016

traviskaufman Dec 19, 2016

traviskaufman Dec 19, 2016

traviskaufman Dec 19, 2016

traviskaufman Dec 19, 2016

traviskaufman Dec 19, 2016

traviskaufman Dec 19, 2016

traviskaufman Dec 19, 2016

Thanood commented Dec 19, 2016

traviskaufman left a comment

traviskaufman Dec 19, 2016

traviskaufman Dec 19, 2016

traviskaufman Dec 19, 2016

Thanood commented Dec 19, 2016

traviskaufman commented Dec 20, 2016

		@@ -0,0 +1,4 @@
		// Place your settings in this file to overwrite default and user settings.

		@@ -1,8 +1,10 @@
		import {bindable, customAttribute, inject, DOM} from 'aurelia-framework';

		// Use webpack's require function to load the css

		@@ -2,10 +2,13 @@ import {bindable, customAttribute, inject, DOM} from 'aurelia-framework';

		// Since we don't have typings (yet) we require mdc-ripple manually.

fix(framework-examples): fix Aurelia example (#120) #126

fix(framework-examples): fix Aurelia example (#120) #126

Conversation

Thanood commented Dec 17, 2016

traviskaufman left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Thanood commented Dec 19, 2016

traviskaufman left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Thanood commented Dec 19, 2016

traviskaufman commented Dec 20, 2016