Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(drawer): update radio button ids to correct add/remove classes on demos #1883

Merged
merged 6 commits into from
Jan 6, 2018
+8 −9
Merged

fix(drawer): update radio button ids to correct add/remove classes on demos #1883

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d1c2848
fix(drawer): update radio button ids to correct add/remove classes on…
Jan 5, 2018
50064ab
Merge branch 'master' into fix/drawer/custom-mixins-radios
Jan 5, 2018
fb20f26
Merge branch 'master' into fix/drawer/custom-mixins-radios
Jan 5, 2018
6636d96
Merge branch 'master' into fix/drawer/custom-mixins-radios
Jan 6, 2018
4462a44
Merge branch 'master' into fix/drawer/custom-mixins-radios
Jan 6, 2018
60d1651
Merge branch 'master' into fix/drawer/custom-mixins-radios
Jan 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions demos/drawer/permanent-drawer-above-toolbar.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@
</head>
<body class="mdc-typography demo-body">
<nav id="demo-drawer" class="mdc-drawer mdc-drawer--permanent demo-drawer">
<div class="mdc-drawer__toolbar-spacer"></div>
<div class="mdc-list-group">
<nav class="mdc-list">
<a class="mdc-list-item mdc-list-item--selected demo-drawer-list-item" href="#">
Expand Down Expand Up @@ -202,9 +201,9 @@ <h1 class="mdc-typography--display1">Permanent Drawer</h1>
drawerEl.classList.remove('demo-drawer--custom');
drawerEl.classList.remove('demo-drawer--accessible');

if(e.target.id === 'accessible') {
if(e.target.id === 'theme-radio-accessible') {
drawerEl.classList.add('demo-drawer--accessible');
} else if(e.target.id === 'custom') {
} else if(e.target.id === 'theme-radio-custom') {
drawerEl.classList.add('demo-drawer--custom');
}
});
Expand Down
4 changes: 2 additions & 2 deletions demos/drawer/permanent-drawer-below-toolbar.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,9 +193,9 @@ <h1 class="mdc-typography--display1">Permanent Drawer</h1>
drawerEl.classList.remove('demo-drawer--custom');
drawerEl.classList.remove('demo-drawer--accessible');

if(e.target.id === 'accessible') {
if(e.target.id === 'theme-radio-accessible') {
drawerEl.classList.add('demo-drawer--accessible');
} else if(e.target.id === 'custom') {
} else if(e.target.id === 'theme-radio-custom') {
drawerEl.classList.add('demo-drawer--custom');
}
});
Expand Down
4 changes: 2 additions & 2 deletions demos/drawer/persistent-drawer.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,9 +179,9 @@ <h1 class="mdc-typography--display1">Persistent Drawer</h1>
drawerEl.classList.remove('demo-drawer--custom');
drawerEl.classList.remove('demo-drawer--accessible');

if(e.target.id === 'accessible') {
if(e.target.id === 'theme-radio-accessible') {
drawerEl.classList.add('demo-drawer--accessible');
} else if(e.target.id === 'custom') {
} else if(e.target.id === 'theme-radio-custom') {
drawerEl.classList.add('demo-drawer--custom');
}
});
Expand Down
4 changes: 2 additions & 2 deletions demos/drawer/temporary-drawer.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,9 +164,9 @@ <h1 class="mdc-typography--display1">Temporary Drawer</h1>
drawerEl.classList.remove('demo-drawer--custom');
drawerEl.classList.remove('demo-drawer--accessible');

if(e.target.id === 'accessible') {
if(e.target.id === 'theme-radio-accessible') {
drawerEl.classList.add('demo-drawer--accessible');
} else if(e.target.id === 'custom') {
} else if(e.target.id === 'theme-radio-custom') {
drawerEl.classList.add('demo-drawer--custom');
}
});
Expand Down