Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(demos): Re-enable JS source maps #2124

Merged
merged 2 commits into from
Jan 29, 2018
Merged

Conversation

acdvorak
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Jan 29, 2018

Codecov Report

Merging #2124 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2124   +/-   ##
=======================================
  Coverage   99.43%   99.43%           
=======================================
  Files          84       84           
  Lines        3723     3723           
  Branches      486      486           
=======================================
  Hits         3702     3702           
  Misses         21       21

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d461374...c16d6d5. Read the comment docs.

Copy link
Contributor

@kfranqueiro kfranqueiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with expectation that we can probably remove one or more other variables that are mostly meaningless now.

@acdvorak acdvorak merged commit 929eb8c into master Jan 29, 2018
@acdvorak acdvorak deleted the fix/demos/js-sourcemaps branch January 29, 2018 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants