-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Move demo Webpack config to separate file #2325
Merged
Merged
Changes from 11 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
da9f268
chore: Refactor JS bundle factory code into scripts/webpack/
acdvorak 2e07c8d
WIP: Add @fileoverview to js-bundle-factory.js
acdvorak f661068
WIP: Remove unnecessary array
acdvorak f8d62ba
WIP: Use PathResolver for consistency
acdvorak 90c7ebf
WIP: Use consistent absolute path style
acdvorak e54c250
chore: Extract webpack.demo.js from webpack.config.js
acdvorak b61e1c0
Revert "chore: Extract webpack.demo.js from webpack.config.js"
acdvorak 102f6cf
chore: Move demo Webpack config to separate file
acdvorak 0da48bf
Revert "chore: Move demo Webpack config to separate file"
acdvorak 124064b
Merge branch 'master' into chore/build/demo-webpack-config
acdvorak b3790ee
chore: Move demo Webpack config to separate file
acdvorak e204154
Merge remote-tracking branch 'origin' into chore/build/demo-webpack-c…
acdvorak 205e519
WIP: Remove unused variable
acdvorak 06ef11a
WIP: Centralize devServer properties
acdvorak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| /** | ||
| * Copyright 2016 Google Inc. All Rights Reserved. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| 'use strict'; | ||
|
|
||
| const CssBundleFactory = require('../scripts/webpack/css-bundle-factory'); | ||
| const Environment = require('../scripts/build/environment'); | ||
| const Globber = require('../scripts/webpack/globber'); | ||
| const JsBundleFactory = require('../scripts/webpack/js-bundle-factory'); | ||
| const PathResolver = require('../scripts/build/path-resolver'); | ||
| const PluginFactory = require('../scripts/webpack/plugin-factory'); | ||
|
|
||
| const env = new Environment(); | ||
| env.setBabelEnv(); | ||
|
|
||
| const pathResolver = new PathResolver(); | ||
| const globber = new Globber({pathResolver}); | ||
| const pluginFactory = new PluginFactory({globber}); | ||
| const copyrightBannerPlugin = pluginFactory.createCopyrightBannerPlugin(); | ||
| const cssBundleFactory = new CssBundleFactory({env, pathResolver, globber, pluginFactory}); | ||
| const jsBundleFactory = new JsBundleFactory({env, pathResolver, globber, pluginFactory}); | ||
|
|
||
| const OUTPUT = { | ||
| httpDirAbsolutePath: '/assets/', | ||
| }; | ||
|
|
||
| module.exports = [ | ||
| mainJsCombined(), | ||
| demoCss(), | ||
| demoJs(), | ||
| ]; | ||
|
|
||
| function mainJsCombined() { | ||
| return jsBundleFactory.createMainJsCombined({output: OUTPUT}); | ||
| } | ||
|
|
||
| function demoJs() { | ||
| return jsBundleFactory.createCustomJs({ | ||
| bundleName: 'demo-js', | ||
| chunks: { | ||
| 'common': pathResolver.getAbsolutePath('./demos/common.js'), | ||
| 'theme/index': pathResolver.getAbsolutePath('./demos/theme/index.js'), | ||
| }, | ||
| output: Object.assign({}, OUTPUT, { | ||
| filename: '[name].js', | ||
| library: ['demo', '[name]'], | ||
| }), | ||
| plugins: [ | ||
| copyrightBannerPlugin, | ||
| ], | ||
| }); | ||
| } | ||
|
|
||
| function demoCss() { | ||
| return cssBundleFactory.createCustomCss({ | ||
| bundleName: 'demo-css', | ||
| chunkGlobConfig: { | ||
| inputDirectory: '/demos', | ||
| }, | ||
| output: OUTPUT, | ||
| plugins: [ | ||
| copyrightBannerPlugin, | ||
| ], | ||
| }); | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When do we set the config to
/webpack.config.jsfor production?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
build,build:min, anddistcommands are used for production builds, so they remain unchanged. If you don't specify a config file, Webpack implicitly uses/webpack.config.jsby default.devis only used for demos 🙂