Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Compile demo CSS/JS during npm run build #2437

Merged
merged 2 commits into from
Mar 19, 2018
Merged

Conversation

acdvorak
Copy link
Contributor

@acdvorak acdvorak commented Mar 19, 2018

Fixes a regression introduced by #2325.

Supersedes #2433.

To verify:

  1. Build and deploy to staging server:
    MDC_ENV=development npm run build && gcloud app deploy app.yaml --project google.com:mdc-web-dev --version $USER
  2. View the staging server:
    http://$USER.material-components-web.appspot.com
    

@codecov-io
Copy link

codecov-io commented Mar 19, 2018

Codecov Report

Merging #2437 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2437   +/-   ##
=======================================
  Coverage   98.86%   98.86%           
=======================================
  Files         101      101           
  Lines        4151     4151           
  Branches      531      531           
=======================================
  Hits         4104     4104           
  Misses         47       47

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6417b51...7b8aca4. Read the comment docs.

Copy link
Contributor

@williamernest williamernest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and deploys fine. LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants