Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(infrastructure): Delete Webpack config tests #2450

Merged
merged 2 commits into from
Mar 22, 2018

Conversation

acdvorak
Copy link
Contributor

No longer needed now that Webpack config refactoring is complete.

Refs #1994

No longer needed now that Webpack config refactoring is complete.

Refs #1994
@codecov-io
Copy link

Codecov Report

Merging #2450 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2450   +/-   ##
=======================================
  Coverage   98.91%   98.91%           
=======================================
  Files         104      104           
  Lines        4234     4234           
  Branches      534      534           
=======================================
  Hits         4188     4188           
  Misses         46       46

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 819d139...a5c8fa5. Read the comment docs.

acdvorak added a commit that referenced this pull request Mar 22, 2018
Copy link
Contributor

@patrickrodee patrickrodee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested everything that webpack touches and it's all bueno. Nicely done! This was a huge change and all works wonderfully 👏 👏 👏

@acdvorak acdvorak merged commit 9e5d646 into master Mar 22, 2018
@acdvorak acdvorak deleted the chore/test/delete-webpack-config-test branch March 22, 2018 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants