chore(dialog): Remove ripple layout & layoutFooterRipples adapter API #2570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 16, 2018 11:07
Unbounded still needs layout called immediately to compute its position.
Ripple now calls layout upon activation. The layoutFooterRipples adapter API is no longer used and can be removed.
williamernest
approved these changes
Apr 16, 2018
| const stubbedLayout = td.func('MDCRipple#layout'); | ||
|
|
||
| before(() => { | ||
| MDCRipple.prototype.layout = stubbedLayout; |
There was a problem hiding this comment.
Remove import of MDCRipple
24:9 error 'MDCRipple' is defined but never used. Allowed unused vars must match /^(?:(?:MDC(?:(?:[A-Z][a-z0-9]+)+)Adapter)|(?:(?:(?:[A-Z][a-z0-9]+)+)Type))$/ no-unused-vars
kfranqueiro
changed the base branch from
feat/ripple-layout-on-activate
to
master
Codecov Report
@@ Coverage Diff @@
## master #2570 +/- ##
=========================================
Coverage ? 98.76%
=========================================
Files ? 98
Lines ? 4195
Branches ? 535
=========================================
Hits ? 4143
Misses ? 52
Partials ? 0
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ripple now calls layout upon activation.
The layoutFooterRipples adapter API is no longer used and can be removed.
Requires #2567 (which this PR is based on).