Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(text-field): Changes to text area label positioning to cover text content #2816

Merged
merged 9 commits into from
May 30, 2018
Merged

fix(text-field): Changes to text area label positioning to cover text content #2816

merged 9 commits into from
May 30, 2018

Conversation

abhiomkar
Copy link
Collaborator

@abhiomkar abhiomkar commented May 24, 2018 •
edited
Loading

Fixes #2392

Other changes:

  • RTL position fix for text area label.
  • User can now scroll the text area content when hovering on label.

@abhiomkar abhiomkar requested a review from williamernest May 24, 2018 23:07
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@codecov-io
Copy link

codecov-io commented May 24, 2018 •
edited
Loading

Codecov Report

Merging #2816 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2816   +/-   ##
=======================================
  Coverage   98.42%   98.42%           
=======================================
  Files          98       98           
  Lines        4203     4203           
  Branches      534      534           
=======================================
  Hits         4137     4137           
  Misses         66       66

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91b47d5...20acb41. Read the comment docs.

@kfranqueiro kfranqueiro force-pushed the fix_textfield_textarea_label_fullwidth_issue2392 branch from e0b857e to 8de0d23 Compare May 25, 2018 16:06
@googlebot
Copy link

CLAs look good, thanks!

@kfranqueiro
Copy link
Contributor

Discussed with Abhinay; we're going to pull the RTL changes (plus the dependent change in Top App Bar) into its own feat(rtl) PR first, then merge this purely as fix(text-field).

@abhiomkar abhiomkar mentioned this pull request May 25, 2018
Merged
@abhiomkar
fix(text-field): Changes to text area label positioning to cover text…
4458c28 
… content.

Other changes:
  - RTL position fix for text area label.
  - User can now scroll the text area content when hovering on label.
@abhiomkar abhiomkar force-pushed the fix_textfield_textarea_label_fullwidth_issue2392 branch from 8de0d23 to 4458c28 Compare May 25, 2018 16:34
@abhiomkar abhiomkar changed the title Changes to text area label positioning to cover text content fix(text-field): Changes to text area label positioning to cover text content May 25, 2018
@abhiomkar
Copy link
Collaborator Author

Created a separate PR #2823 for making rtl sass mixin public.

@abhiomkar abhiomkar requested a review from kfranqueiro May 29, 2018 18:12
kfranqueiro
kfranqueiro approved these changes May 30, 2018
View reviewed changes
Copy link
Contributor

@kfranqueiro kfranqueiro left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested across browsers on Windows / Mac / Linux and Chrome on Android. The most I could find is that the system text scaling level on Windows / Linux can affect rendering such that the label background may overlap by at most one pixel, but for the most part this works and it properly covers the underlying text value everywhere.

kfranqueiro
kfranqueiro suggested changes May 30, 2018
View reviewed changes
packages/mdc-textfield/_mixins.scss Outdated

@include mdc-rtl-reflexive(left, 1px, right, 0);
@include mdc-rtl-reflexive-property(margin, 8px, 0);

Copy link
Contributor

@kfranqueiro kfranqueiro May 30, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint is failing due to the indentation on this empty line

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@abhiomkar abhiomkar merged commit d6f4dc1 into master May 30, 2018
@kfranqueiro kfranqueiro deleted the fix_textfield_textarea_label_fullwidth_issue2392 branch May 31, 2018 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfranqueiro kfranqueiro kfranqueiro approved these changes

@williamernest williamernest Awaiting requested review from williamernest

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Label in TextArea should be full width, and not show any TextArea text above the label
4 participants
@abhiomkar @googlebot @codecov-io @kfranqueiro