-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(list): Updated two-line list to use typography baseline to match spec. #3085
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is related to #3083 ...but I didn't realize our mdc-list-item__secondary-text
is inside our mdc-list-item__text
. Why do we do that??
Can we have change our list HTML structure to be:
<li class="mdc-list-item">
<span class="mdc-list-item__text">
First-line text
</span>
<span class="mdc-list-item__secondary-text">
Second-line text
</span>
</li>
That would be more logical right?
or maybe we need another element, to separate the graphic from the two lines of text
<li class="mdc-list-item">
<span class="mdc-list-item__graphic">
<i class="material-icons">folder</i>
</span>
<div class="mdc-list-item__body">
<span class="mdc-list-item__text">
First-line text
</span>
<span class="mdc-list-item__secondary-text">
Second-line text
</span>
</div>
</li>
packages/mdc-list/mdc-list.scss
Outdated
$mdc-list-item-secondary-text-baseline-height_: 20px; | ||
|
||
$mdc-list-dense-item-primary-text-baseline-height_: 24px; | ||
$mdc-list-dense-item-secondary-text-baseline-height_: 20px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the dense version is the same as the regular version...then you probably dont need it?
Codecov Report
@@ Coverage Diff @@
## master #3085 +/- ##
=======================================
Coverage 98.13% 98.13%
=======================================
Files 101 101
Lines 4444 4444
Branches 585 585
=======================================
Hits 4361 4361
Misses 83 83 Continue to review full report at Codecov.
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
CLAs look good, thanks! |
🤖 Beep boop! Screenshot test reportCommit 25b6419 vs. No diffs! 💯🎉 |
🤖 Beep boop! Screenshot test reportCommit 628769f vs. No diffs! 💯🎉 |
BREAKING CHANGE
Fixes #3038