Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(list): Updated two-line list to use typography baseline to match spec. #3085

Merged
merged 14 commits into from
Jul 25, 2018

Conversation

abhiomkar
Copy link
Collaborator

@abhiomkar abhiomkar commented Jul 16, 2018

BREAKING CHANGE

Fixes #3038

Copy link
Contributor

@lynnmercier lynnmercier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is related to #3083 ...but I didn't realize our mdc-list-item__secondary-text is inside our mdc-list-item__text. Why do we do that??

image

Can we have change our list HTML structure to be:

<li class="mdc-list-item">
  <span class="mdc-list-item__text">
    First-line text
  </span>
  <span class="mdc-list-item__secondary-text">
    Second-line text
  </span>
</li>

That would be more logical right?

or maybe we need another element, to separate the graphic from the two lines of text

<li class="mdc-list-item">
  <span class="mdc-list-item__graphic">
    <i class="material-icons">folder</i>
  </span>
  <div class="mdc-list-item__body">
    <span class="mdc-list-item__text">
      First-line text
    </span>
    <span class="mdc-list-item__secondary-text">
      Second-line text
    </span>
  </div>
</li>

$mdc-list-item-secondary-text-baseline-height_: 20px;

$mdc-list-dense-item-primary-text-baseline-height_: 24px;
$mdc-list-dense-item-secondary-text-baseline-height_: 20px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the dense version is the same as the regular version...then you probably dont need it?

@codecov-io
Copy link

codecov-io commented Jul 25, 2018

Codecov Report

Merging #3085 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3085   +/-   ##
=======================================
  Coverage   98.13%   98.13%           
=======================================
  Files         101      101           
  Lines        4444     4444           
  Branches      585      585           
=======================================
  Hits         4361     4361           
  Misses         83       83

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd3817a...628769f. Read the comment docs.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@williamernest williamernest changed the base branch from typography_text_baseline to master July 25, 2018 15:58
@williamernest williamernest changed the base branch from master to typography_text_baseline July 25, 2018 15:59
@williamernest williamernest changed the base branch from typography_text_baseline to master July 25, 2018 16:02
@googlebot
Copy link

CLAs look good, thanks!

@mdc-web-bot
Copy link
Collaborator

🤖 Beep boop!

Screenshot test report

Commit 25b6419 vs. master:

No diffs! 💯🎉

@mdc-web-bot
Copy link
Collaborator

🤖 Beep boop!

Screenshot test report

Commit 628769f vs. master:

No diffs! 💯🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants