feat(tab): Update tab color and typography #3108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## feat/tabs/tabs #3108 +/- ##
===============================================
Coverage 98.41% 98.41%
===============================================
Files 113 113
Lines 4790 4790
Branches 600 600
===============================================
Hits 4714 4714
Misses 76 76Continue to review full report at Codecov.
|
kfranqueiro
suggested changes
Jul 17, 2018
packages/mdc-tab/mdc-tab.scss
Outdated
| font-size: 14px; | ||
| font-weight: 500; | ||
| opacity: $mdc-tab-text-label-opacity; | ||
| line-height: 1; |
There was a problem hiding this comment.
Is this overriding mdc-typography(button) on .mdc-tab above? If so, should we just put this there with a comment to make it clearer?
kfranqueiro
approved these changes
Jul 17, 2018
patrickrodee
added a commit
that referenced
this pull request
Jul 18, 2018
kfranqueiro
pushed a commit
that referenced
this pull request
Jul 27, 2018
WIP fixed bg coloring of icons fix(tab-indicator): Use absolute positioning (#2547) WIP start of tab scroller WIP fixed transition duration WIP progress on scroller WIP added demos back chore(tabs): Removed tab scroller feat(tabs): Add tab indicator inside tab (#2565) feat(tab-scroller): Add tab scroller (#2577) Merge master into feat/tabs/tabs (#3096) feat(tab): Update tab color and typography (#3108) docs(tabs): Update metadata and synopses (#3117) feat(tab): Add MDCTabDimensions computation (#3122) feat(tab): Emit selection and activation events (#3139) docs(tabs): Update new READMEs to match standard (#3142) feat(tab): Give focus to tab when activated (#3164) feat(tab): Add mixin for parent positioning; Use mixin in tab scroller (#3179) fix(tabs): Suppress area occupied by scrollbar on platforms that show it (#3149) fix(tab): Remove extraneous padding from the stacked text label in LTR (#3193) feat(tabs): Add missing docs and create helper util API (#3194) Merge master into feat/tabs/tabs (#3227) feat(tab): Update layout; Add fixed-width mixin; Add min-width class (#3220) fix(tab-scroller): Fix incorrect animation stopping scroll value in RTL (#3237) feat(tab-scroller): Add scroll content width method for use in tab bar (#3222) feat(tab): Remove activation event emitting (#3242) feat(tab-bar): Add tab bar (#3229)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the use of color and typography in MDCTab to use the most-recent mixins. Add variables for icon size, tab height, text label opacity, and icon opacity. Closes #3058