fix(theme): Example of runtime TextField theming fix #3145
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to be more of an example than anything, but if the contributors are ok with this approach, I'd be happy to go ahead and apply this to the whole codebase.
The issue
This is an example of setting red as the
mdc-theme-primary
color at runtime, and the resultingmdc-floating-label
still using the default purple theme color.The short version
Anytime the
mdc-theme-prop-value
function is used in SASS, the value is being hardcoded into the CSS which means you can never override it with the runtime css variables. The issue is compounded by using thergba
function to add opacity to the color.Proposed fixes / Ideas
Why don't you just recompile the SASS?
I have apps that use themes in a variety of ways