Chore(switch): Merge master into switch update #3235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fetches `$TRAVIS_BRANCH` and `$TRAVIS_PULL_REQUEST_BRANCH` git branches to ensure they are available for subsequent `git log` queries
…#3228) Also: - Fixes typo in `getStackTrace()`
### What it does
- (Hopefully) Fixes failing screenshot tests on Travis for merges into `master`
- Uses the `TRAVIS_COMMIT` env var instead of querying `git`
- Looking up the commit with `git rev-parse master` seems to fail on Travis for some reason
- Stops trying to set GitHub commit status if API credentials are not found
- Previously, this would throw an error and kill the whole test
- Adds a bit of logging
Codecov Report
@@ Coverage Diff @@
## feat/switch-update #3235 +/- ##
===================================================
Coverage 98.13% 98.13%
===================================================
Files 104 104
Lines 4512 4512
Branches 587 587
===================================================
Hits 4428 4428
Misses 84 84Continue to review full report at Codecov.
|
|
All 140 screenshot tests passed for commit a3332e4 vs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix Travis screenshot failures.