Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(text-field): Stop emitting unused CSS in Text Field & Select #3293

Merged
merged 3 commits into from
Aug 3, 2018
Merged

fix(text-field): Stop emitting unused CSS in Text Field & Select #3293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ab3d837
fix(text-field): Stop emitting unused CSS in Text Field & Select
Aug 3, 2018
2c9a728
Merge branch 'master' into fix/text-field/remove-pointless-ripple-css
kfranqueiro Aug 3, 2018
ff3e1e0
Merge branch 'master' into fix/text-field/remove-pointless-ripple-css
kfranqueiro Aug 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions packages/mdc-select/mdc-select.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,10 +98,7 @@
// Select Box intentionally omits press ripple, so each state needs to be specified individually
@include mdc-states-base-color($mdc-select-ink-color);
@include mdc-states-hover-opacity(mdc-states-opacity($mdc-select-ink-color, hover));
@include mdc-states-focus-opacity(
mdc-states-opacity($mdc-select-ink-color, focus),
$has-nested-focusable-element: true
);
@include mdc-states-focus-opacity(mdc-states-opacity($mdc-select-ink-color, focus));

height: 56px;
border-radius: 4px 4px 0 0;
Expand Down
5 changes: 1 addition & 4 deletions packages/mdc-textfield/_mixins.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,10 +326,7 @@
// Text Field Box intentionally omits press ripple, so each state needs to be specified individually
@include mdc-states-base-color($mdc-text-field-ink-color);
@include mdc-states-hover-opacity(mdc-states-opacity($mdc-text-field-ink-color, hover));
@include mdc-states-focus-opacity(
mdc-states-opacity($mdc-text-field-ink-color, focus),
$has-nested-focusable-element: true
);
@include mdc-states-focus-opacity(mdc-states-opacity($mdc-text-field-ink-color, focus));
@include mdc-ripple-radius-bounded;
@include mdc-text-field-box-corner-radius($mdc-text-field-border-radius);
@include mdc-text-field-box-fill-color($mdc-text-field-box-background);
Expand Down