Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dialog): Expose numbers on foundation #3346

Merged
merged 1 commit into from
Aug 14, 2018
Merged

fix(dialog): Expose numbers on foundation #3346

merged 1 commit into from
Aug 14, 2018

Conversation

kfranqueiro
Copy link
Contributor

Fixes #3345.

@mdc-web-bot
Copy link
Collaborator

All 349 screenshot tests passed for commit cea81eb vs. master! 💯🎉

@codecov-io
Copy link

codecov-io commented Aug 14, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@4cc16d9). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3346   +/-   ##
=========================================
  Coverage          ?   98.14%           
=========================================
  Files             ?      123           
  Lines             ?     5217           
  Branches          ?      638           
=========================================
  Hits              ?     5120           
  Misses            ?       97           
  Partials          ?        0
Impacted Files Coverage Δ
packages/mdc-dialog/foundation.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cc16d9...cea81eb. Read the comment docs.

williamernest
williamernest approved these changes Aug 14, 2018
View reviewed changes
Copy link
Contributor

@williamernest williamernest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kfranqueiro kfranqueiro merged commit 8f35741 into master Aug 14, 2018
@kfranqueiro kfranqueiro deleted the fix/dialog-numbers branch August 14, 2018 17:27
@kfranqueiro kfranqueiro mentioned this pull request Aug 16, 2018
Merged
adrianschmidt pushed a commit to Lundalogik/material-components-web that referenced this pull request Sep 25, 2018
@kfranqueiro
fix(dialog): Expose numbers on foundation (material-components#3346)
8aa7ae0 
(cherry picked from commit 8f35741)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williamernest williamernest williamernest approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kfranqueiro @mdc-web-bot @codecov-io @williamernest