feat(drawer): Allow customizing drawer width #3459
Conversation
|
All 349 screenshot tests passed for commit b406aed vs. |
|
🤖 Beep boop! Screenshot test report 🚦4 screenshots changed from Details4 Added: |
|
🤖 Beep boop! Screenshot test report 🚦4 screenshots changed from Details4 Added: |
packages/mdc-drawer/README.md
Outdated
| @@ -320,6 +320,7 @@ Mixin | Description | |||
| `mdc-drawer-activated-overlay-color($color)` | Sets the overlay color of the activated drawer list item. | |||
| `mdc-drawer-scrim-fill-color($color)` | Sets the fill color of `mdc-drawer-scrim`. | |||
| `mdc-drawer-z-index($value)` | Sets the z index of drawer. Drawer stays on top of top app bar except for clipped variant of drawer. | |||
| `mdc-drawer-width($width)` | Sets the width of drawer and margin space required for `mdc-drawer-app-content` in case of dismissible variant. | |||
There was a problem hiding this comment.
IMO this can be a little hard to read/parse (esp. the part that is dismissible-specific).
Sets the width of the drawer. In the case of the dismissible variant, also sets margin required for `mdc-drawer-app-content`.
packages/mdc-drawer/_mixins.scss
Outdated
|
|
||
| @mixin mdc-drawer-width($width) { | ||
| width: $width; | ||
| max-width: $width; |
There was a problem hiding this comment.
I know this was already here, but I forget, why'd we need both width and max-width?
There was a problem hiding this comment.
Good point. Removed.
|
The latest screenshot test results seem to be showing a bunch of diffs I wouldn't expect. It looks like there's more content in the snapshot images (look at the scrollbars)... |
|
🤖 Beep boop! Screenshot test report 🚦24 screenshots changed from |
|
🤖 Beep boop! Screenshot test report 🚦24 screenshots changed from |
|
🤖 Beep boop! Screenshot test report 🚦24 screenshots changed from |
Fixes #2603