Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): Remove blue background in IE on focus #3497

Merged
merged 13 commits into from
Sep 5, 2018
Merged

fix(select): Remove blue background in IE on focus #3497

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
c7654af
fix(select): Remove blue background in IE on focus
acdvorak Sep 2, 2018
42dd975
WIP: Add test page for issue #3496 and fix Edge autofocus bug
acdvorak Sep 2, 2018
6e2d3e3
WIP: Update URL in comment
acdvorak Sep 2, 2018
f85f4c9
WIP: Remove changes (moved to PR #3499)
acdvorak Sep 2, 2018
5d4f602
Merge remote-tracking branch 'origin/master' into fix/select/ie-highl…
acdvorak Sep 2, 2018
8e370ba
Merge remote-tracking branch 'origin/master' into fix/select/ie-highl…
acdvorak Sep 3, 2018
9bd6052
WIP: Combine `3230.html` and `3496.html` into one file
acdvorak Sep 5, 2018
1b65fc8
Merge remote-tracking branch 'origin/master' into fix/select/ie-highl…
acdvorak Sep 5, 2018
fe7a3cc
WIP: Update `golden.json`
acdvorak Sep 5, 2018
a524bb2
WIP: Re-indent HTML
acdvorak Sep 5, 2018
ab419f3
Merge remote-tracking branch 'origin/master' into fix/select/ie-highl…
acdvorak Sep 5, 2018
e1ff9f0
Merge branch 'master' into fix/select/ie-highlight
williamernest Sep 5, 2018
53e9c7f
fix(select): Update goldens
williamernest Sep 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/mdc-select/mdc-select.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,11 @@
display: none;
}

&::-ms-value {
background-color: transparent;
color: inherit;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would replacing this with @include mdc-select-ink-color($mdc-select-ink-color); obviate the need for #3513?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we still need both PRs.

mdc-select-ink-color() specifically excludes --disabled, which is why the browser's default font color was getting used.

We either need to update mdc-select-ink-color() so that it includes --disabled, or set a disabled-specific color.

It seems like the simplest thing is to set the color once at a high level, and have all children just inherit it.

}

// counteracts the extra text padding that Firefox adds by default
@-moz-document url-prefix("") {
text-indent: -2px;
Expand Down
13 changes: 11 additions & 2 deletions test/screenshot/golden.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,12 +396,21 @@
}
},
"spec/mdc-select/issues/3230.html": {
"public_url": "https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2018/08/28/00_57_26_335/spec/mdc-select/issues/3230.html",
"public_url": "https://storage.googleapis.com/mdc-web-screenshot-tests/advorak/2018/09/02/18_08_57_688/spec/mdc-select/issues/3230.html?utm_source=golden_json",
"screenshots": {
"desktop_windows_chrome@latest": "https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2018/08/28/00_57_26_335/spec/mdc-select/issues/3230.html.windows_chrome_68.png",
"desktop_windows_edge@latest": "https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2018/08/28/00_57_26_335/spec/mdc-select/issues/3230.html.windows_edge_17.png",
"desktop_windows_firefox@latest": "https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2018/08/28/00_57_26_335/spec/mdc-select/issues/3230.html.windows_firefox_61.png",
"desktop_windows_ie@11": "https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2018/08/28/00_57_26_335/spec/mdc-select/issues/3230.html.windows_ie_11.png"
"desktop_windows_ie@11": "https://storage.googleapis.com/mdc-web-screenshot-tests/advorak/2018/09/02/18_08_57_688/spec/mdc-select/issues/3230.html.windows_ie_11.png"
}
},
"spec/mdc-select/issues/3496.html": {
"public_url": "https://storage.googleapis.com/mdc-web-screenshot-tests/advorak/2018/09/02/19_06_54_751/spec/mdc-select/issues/3496.html?utm_source=golden_json",
"screenshots": {
"desktop_windows_chrome@latest": "https://storage.googleapis.com/mdc-web-screenshot-tests/advorak/2018/09/02/18_27_17_064/spec/mdc-select/issues/3496.html.windows_chrome_68.png",
"desktop_windows_edge@latest": "https://storage.googleapis.com/mdc-web-screenshot-tests/advorak/2018/09/02/19_06_54_751/spec/mdc-select/issues/3496.html.windows_edge_17.png",
"desktop_windows_firefox@latest": "https://storage.googleapis.com/mdc-web-screenshot-tests/advorak/2018/09/02/18_27_17_064/spec/mdc-select/issues/3496.html.windows_firefox_61.png",
"desktop_windows_ie@11": "https://storage.googleapis.com/mdc-web-screenshot-tests/advorak/2018/09/02/18_27_17_064/spec/mdc-select/issues/3496.html.windows_ie_11.png"
}
},
"spec/mdc-switch/classes/baseline.html": {
Expand Down
70 changes: 70 additions & 0 deletions test/screenshot/spec/mdc-select/issues/3496.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@
<!DOCTYPE html>
<!--
Copyright 2018 Google Inc.

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in
all copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
THE SOFTWARE.
-->
<html lang="en">
<head>
<meta charset="utf-8">
<title>Issue 3496 - MDC Web Screenshot Test</title>
<meta name="viewport" content="width=device-width, initial-scale=1">
<link rel="stylesheet" href="../../../out/mdc.select.css">
<link rel="stylesheet" href="../../../out/mdc.typography.css">
<link rel="stylesheet" href="../../../out/spec/fixture.css">
<link rel="stylesheet" href="../../../out/spec/mdc-select/fixture.css">
</head>

<body class="test-container mdc-typography">
<main class="test-viewport test-viewport--mobile">
<div class="test-layout">

<!-- This tests that select suppresses IE's default blue background on focus -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need a new screenshot page for this. We can add these comments to the 3230.html page stating that the first select is verifying both issues. Maybe rename the file 3230_3496.html?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

<!-- See https://github.com/material-components/material-components-web/issues/3496 -->
<div class="test-cell test-cell--select">
<div class="mdc-select mdc-select--outlined">
<select class="mdc-select__native-control" id="my-select" autofocus>
<option value="grains" selected>
Bread, Cereal, Rice, and Pasta
</option>
<option value="vegetables" disabled>
Vegetables
</option>
</select>
<div class="mdc-notched-outline mdc-notched-outline--notched">
<svg>
<path class="mdc-notched-outline__path"/>
</svg>
</div>
<div class="mdc-notched-outline__idle"></div>
</div>
</div>

</div>
</main>

<!-- Automatically provides/replaces `Promise` if missing or broken. -->
<script src="https://cdn.jsdelivr.net/npm/es6-promise@4/dist/es6-promise.js"></script>
<script src="https://cdn.jsdelivr.net/npm/es6-promise@4/dist/es6-promise.auto.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/fontfaceobserver/2.0.13/fontfaceobserver.standalone.js"></script>
<script src="../../../out/material-components-web.js"></script>
<script src="../../../out/spec/fixture.js"></script>
<script src="../../../out/spec/mdc-select/fixture.js"></script>
</body>
</html>