Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(infrastructure): Add npm run lint:html for screenshot pages #3502

Merged
merged 11 commits into from
Sep 4, 2018

Conversation

acdvorak
Copy link
Contributor

@acdvorak acdvorak commented Sep 3, 2018

What it does

  • Adds npm run lint:html command
    • Runs against test/screenshot/spec/**/*.html files (excluding index.html)
  • Adds root .htmllintrc config file
    • Unfortunately, htmllint doesn't support disabling individual rules with inline comments.
    • However, you can disable all rules with a comment block:
      <a>Allowed tag</a>
      
      <!-- htmllint-disable -->
      <b>Banned tag</b>
      <!-- htmllint-enable -->
      
      <code>Allowed tag</code>
  • Fixes linter errors in button, card, drawer, radio, switch, and textfield pages'
  • Adds <label> elements to radio and switch pages:
    radio page screenshot
    switch page screenshot

How to test

npm run lint:html

@codecov-io
Copy link

codecov-io commented Sep 3, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@cd28c19). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #3502   +/-   ##
========================================
  Coverage          ?   98.4%           
========================================
  Files             ?     119           
  Lines             ?    5028           
  Branches          ?     618           
========================================
  Hits              ?    4948           
  Misses            ?      80           
  Partials          ?       0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd28c19...f417586. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants