feat(select): Add value retrieval mechanisms to JS API #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeelan0319
suggested changes
Feb 24, 2017
packages/mdc-select/README.md
Outdated
| @@ -293,6 +297,10 @@ within `componentDidUpdate`. | |||
|
|
|||
| ### The full foundation API | |||
|
|
|||
| #### MDCSelectFoundation.getValue() => string | |||
|
|
|||
| Returns the value of the currently selected option. | |||
There was a problem hiding this comment.
Maybe also document when invalid what happens if user haven't made any choice.
"Returns the value of the currently selected option. If none of options is selected yet, return empty string."
- Add `value` property to JS component to retrieve the value of the currently selected option - Add `getValue()` method to foundation in order to drive `value` property in component. - Add `getValueForOptionAtIndex` foundation method. - Enhance `verifyDefaultAdapter` foundation test helper by making it so that when checking for correct adapter methods, the method names don't have to be in the same order as they are defined on the object. BREAKING CHANGE: **New adapter method:** `getValueForOptionAtIndex(index: string) => string` should return the "value" of the option at the given index. Please add this method to your adapter implementations. Resolves #232
traviskaufman
force-pushed
the
feat/select-value-property
branch
from
529f176 to
279ba99
Compare
|
@yeelan0319 changes made PTAL 👀 |
yeelan0319
approved these changes
Feb 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
valueproperty to JS component to retrieve the value of thecurrently selected option
getValue()method to foundation in order to drivevalueproperty in component.
getValueForOptionAtIndexfoundation method.verifyDefaultAdapterfoundation test helper by making it sothat when checking for correct adapter methods, the method names don't
have to be in the same order as they are defined on the object.
BREAKING CHANGE: New adapter method:
getValueForOptionAtIndex(index: string) => stringshould return the "value" of the option at the given index. Please add
this method to your adapter implementations.
Resolves #232