feat(ripple): Implement subset of improved interaction response guide… #363

cristobalchao · 2017-02-28T00:21:57Z

feat(ripple): Implement subset of improved interaction response guidelines for ripple

Resolves #190

traviskaufman

I think that these changes need some tests to go along with them to cover the new logic introduced in the source file

traviskaufman · 2017-03-01T23:33:53Z

packages/mdc-ripple/foundation.js

@@ -146,12 +148,20 @@ export default class MDCRippleFoundation extends MDCFoundation {

    activationState.isActivated = true;
    activationState.isProgrammatic = e === null;
+    activationState.isTimeoutDeactivated = false;


I think this, as well as isProgrammatic, need to be added to the return value of defaultActivationState_()

traviskaufman · 2017-03-01T23:34:33Z

packages/mdc-ripple/foundation.js

    activationState.activationEvent = e;
    activationState.wasActivatedByPointer = activationState.isProgrammatic ? false : (
      e.type === 'mousedown' || e.type === 'touchstart' || e.type === 'pointerdown'
    );

    activationState.activationStartTime = Date.now();
+
+    activationState.deactivationTimeout = setTimeout(() => {


same comment as above

…lines for ripple Resolves #190

cristobalchao · 2017-03-02T03:33:04Z

All issues addressed PTAL

…ines-new

traviskaufman

Will there be any updates to the unbounded ripple interaction? I don't see any changes to its UX, nor do I see any tests for the unbounded deactivation classes.

traviskaufman · 2017-03-02T22:45:54Z

test/unit/mdc-ripple/foundation-deactivation.test.js

@@ -101,6 +101,43 @@ testFoundation('runs deactivation UX on public deactivate() call', ({foundation,
  td.verify(adapter.addClass(cssClasses.FG_BOUNDED_ACTIVE_FILL));
 });

+testFoundation('runs deactivation UX mousedown pressed for longer than deactivation timeout',


so for both of these, the tests will actually exit before the setTimeout() code is executed. This is because the tests execute synchronously, so by the time that setTimeout code runs, the test will be finished and any exceptions will be swallowed.

To prevent this, you can use lolex, which we use in our codebase to mock JS timers. You can see examples of this in the following tests:

mdc-checkbox tests

mdc-simple-menu tests

mdc-ripple tests

many more...

traviskaufman · 2017-03-02T23:09:23Z

test/unit/mdc-ripple/foundation-deactivation.test.js

+  mockRaf.flush();
+
+  setTimeout(() => {
+    td.verify(adapter.removeClass(cssClasses.BG_ACTIVE));


Not exactly sure how these tests are different from the ones above...

Should this be verifying that these adapter methods are not called before DEACTIVATION_TIMEOUT_MS?

…lines for ripple Resolves #190

cristobalchao · 2017-03-08T22:12:51Z

All issues addressed PTAL

traviskaufman · 2017-03-09T17:58:01Z

packages/mdc-ripple/constants.js

@@ -53,4 +53,5 @@ export const numbers = {
  UNBOUNDED_TRANSFORM_DURATION_MS: 200,
  PADDING: 10,
  INITIAL_ORIGIN_SCALE: 0.6,
+  DEACTIVATION_TIMEOUT_MSL: 200,


looks like this should be named DEACTIVATION_TIMEOUT_MS instead of DEACTIVATION_TIMEOUT_MSL

…lines for ripple Resolves #190

The "Make Indeterminate" button in the JS checkbox demo is currently not working because the "indeterminate" property is being set on the checkbox _root_ element, rather than the native instance. This commit fixes that. Skipping TravisCI as this is a change to the demo only. [ci skip]

Fixes #375

- Update scripts/pre-release.sh with correct publish command - Update CONTRIBUTING.md releasing section with guidance on what to do when a release goes awry. [ci skip]

…ignore. (#383)

…lines for ripple Resolves #190

googlebot · 2017-03-14T22:22:37Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

cristobalchao force-pushed the feat/implement-improved-interaction-guidelines-new branch from 148a0ec to 0947879 Compare February 28, 2017 19:12

cristobalchao requested a review from traviskaufman February 28, 2017 19:16

cristobalchao force-pushed the feat/implement-improved-interaction-guidelines-new branch 2 times, most recently from 3e110bf to d65cf1b Compare March 1, 2017 00:01

cristobalchao requested a review from sgomes March 1, 2017 22:47

traviskaufman suggested changes Mar 1, 2017

View reviewed changes

feat(ripple): Implement subset of improved interaction response guide…

7eceb51

…lines for ripple Resolves #190

cristobalchao force-pushed the feat/implement-improved-interaction-guidelines-new branch from d65cf1b to 7eceb51 Compare March 2, 2017 00:47

Merge branch 'master' into feat/implement-improved-interaction-guidel…

7911662

…ines-new

traviskaufman suggested changes Mar 2, 2017

View reviewed changes

cristobalchao@google.com added 3 commits March 8, 2017 13:23

feat(ripple): Implement subset of improved interaction response guide…

1cc19ac

…lines for ripple Resolves #190

feat(ripple): Implement subset of improved interaction response guide…

ef7a680

…lines for ripple Resolves #190

feat(ripple): Implement subset of improved interaction response guide…

94b5edf

…lines for ripple Resolves #190

traviskaufman reviewed Mar 9, 2017

View reviewed changes

cristobalchao@google.com and others added 11 commits March 10, 2017 11:55

feat(ripple): Implement subset of improved interaction response guide…

645e58f

…lines for ripple Resolves #190

test(infrastructure): More test coverage (#368)

d876879

fix(checkbox): Ensure correct positioning in RTL context (#381)

9bf03c9

Fixes #375

chore(infrastructure): Publish

2a1df0d

docs(infrastructure): Update CHANGELOG.md

5ae91bd

docs(infrastructure): Fixup Changelog

008f39b

chore(infrastructure): Update release scripts and docs (#384)

b760901

- Update scripts/pre-release.sh with correct publish command - Update CONTRIBUTING.md releasing section with guidance on what to do when a release goes awry. [ci skip]

fix(infrastructure): Update publishConfig.ignore to commands.publish.…

c6970ad

…ignore. (#383)

feat(grid-list): Implement mdc-grid-list (#47) (#359)

e1683f3

feat(ripple): Implement subset of improved interaction response guide…

e2beadf

…lines for ripple Resolves #190

traviskaufman closed this Mar 14, 2017

cristobalchao deleted the feat/implement-improved-interaction-guidelines-new branch March 14, 2017 22:25

cristobalchao restored the feat/implement-improved-interaction-guidelines-new branch March 14, 2017 22:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(ripple): Implement subset of improved interaction response guide… #363

feat(ripple): Implement subset of improved interaction response guide… #363

cristobalchao commented Feb 28, 2017

traviskaufman left a comment

traviskaufman Mar 1, 2017

traviskaufman Mar 1, 2017

cristobalchao commented Mar 2, 2017

traviskaufman left a comment

traviskaufman Mar 2, 2017

traviskaufman Mar 2, 2017

cristobalchao commented Mar 8, 2017 •

edited

Loading

traviskaufman Mar 9, 2017 •

edited

Loading

googlebot commented Mar 14, 2017

feat(ripple): Implement subset of improved interaction response guide… #363

feat(ripple): Implement subset of improved interaction response guide… #363

Conversation

cristobalchao commented Feb 28, 2017

traviskaufman left a comment

Choose a reason for hiding this comment

traviskaufman Mar 1, 2017

Choose a reason for hiding this comment

traviskaufman Mar 1, 2017

Choose a reason for hiding this comment

cristobalchao commented Mar 2, 2017

traviskaufman left a comment

Choose a reason for hiding this comment

traviskaufman Mar 2, 2017

Choose a reason for hiding this comment

traviskaufman Mar 2, 2017

Choose a reason for hiding this comment

cristobalchao commented Mar 8, 2017 • edited Loading

traviskaufman Mar 9, 2017 • edited Loading

Choose a reason for hiding this comment

googlebot commented Mar 14, 2017

cristobalchao commented Mar 8, 2017 •

edited

Loading

traviskaufman Mar 9, 2017 •

edited

Loading