Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ripple): Implement subset of improved interaction response guide… #363

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,34 @@
<a name="0.6.0"></a>
# [0.6.0](https://github.com/material-components/material-components-web/compare/v0.5.0...v0.6.0) (2017-03-06)


### Bug Fixes

* **checkbox:** Ensure correct positioning in RTL context (#381) ([e296032](https://github.com/material-components/material-components-web/commit/e296032)), closes [#375](https://github.com/material-components/material-components-web/issues/375)
* **form-field:** Make gap btn control and label clickable (#373) ([61a65f6](https://github.com/material-components/material-components-web/commit/61a65f6)), closes [#371](https://github.com/material-components/material-components-web/issues/371)
* **framework-examples:** Fix template syntax in VueJS example (#365) ([465a674](https://github.com/material-components/material-components-web/commit/465a674)), closes [(#365](https://github.com/(/issues/365)
* **ripple:** Provide fallbacks for all custom properties (#367) ([d5873f6](https://github.com/material-components/material-components-web/commit/d5873f6))
* **switch:** Remove checkbox references from SCSS (#352) ([ac88267](https://github.com/material-components/material-components-web/commit/ac88267)), closes [#322](https://github.com/material-components/material-components-web/issues/322)
* **textfield:** Adjust labels when initializing pre-filled textfields ([f8d72ba](https://github.com/material-components/material-components-web/commit/f8d72ba)), closes [#300](https://github.com/material-components/material-components-web/issues/300)
* **toolbar:** Correct class name for mdc-toolbar-fixed-adjust (#321) ([cd5238f](https://github.com/material-components/material-components-web/commit/cd5238f)), closes [#320](https://github.com/material-components/material-components-web/issues/320)

### Features

* **menu:** Move current time retrieval to adapter. ([4d0d587](https://github.com/material-components/material-components-web/commit/4d0d587))
* **ripple:** Implement improved graceful degradation ([bfac404](https://github.com/material-components/material-components-web/commit/bfac404))
* **select:** Add value retrieval mechanisms to JS API ([33d2008](https://github.com/material-components/material-components-web/commit/33d2008)), closes [#232](https://github.com/material-components/material-components-web/issues/232)


### BREAKING CHANGES

* select: **New adapter method:** `getValueForOptionAtIndex(index: string) => string`
should return the "value" of the option at the given index. Please add
this method to your adapter implementations.
* menu: adapters have to implement the new `getAccurateTime`
method.



<a name="0.5.0"></a>
# [0.5.0](https://github.com/material-components/material-components-web/compare/v0.4.0...v0.5.0) (2017-02-21)

Expand Down
35 changes: 35 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ they are all set up.

To release MDC-Web, you perform the following steps.

1. Ensure you are on master, and you have the latest changes: run `git fetch && git fetch --tags && git pull` to be sure.
1. Run `./scripts/pre-release.sh`. This will run `npm test`, build MDC-Web, copy the built assets over
to each module's `dist/` folder, and then print out a summary of all of the new versions that
should be used for changed components. The summary is printed out to both the console, as well
Expand All @@ -153,6 +154,40 @@ To release MDC-Web, you perform the following steps.
1. Run `MDC_ENV=development npm run build && gcloud app deploy`. This will deploy demo pages to our [App Engine demo site](https://material-components-web.appspot.com).
1. Call it a day! :tada: :rocket: :package:

#### Aborting from a release

Sometimes, things go wrong :upside_down_face:. A stale repo, misconfigured environment, or
dependency update may cause something in the release pipeline to fail. This will almost always
happen while running lerna's `publish` command. If that does happen, you probably need to reset your
repo to a clean state in order to be able to re-run the command.

**If you make a mistake while inputting new component versions into the lerna prompt**:

Simply `Ctrl+C` / abort the lerna command. No changes should have been made locally.

**If something goes wrong while lerna is creating its publish commit**:

1. After the lerna command fails, run `git reset HEAD`
1. Run `git co -- .`. This will restore the repo to its state before lerna attempted to bump
versions and commit.
1. Re-run the publish command. Note that the new component versions are saved to `.new-versions.log`
in the repo's root directory, which you can use to re-enter the new versions.

**If something goes wrong while lerna is publishing to npm**:

1. `Ctrl+C` / abort the lerna command. Your repo now has a newly created commit and tags that you
have to get rid of in order to re-run the lerna command successfully.
1. Remove the publish commit by running `git reset --hard HEAD~1`.
1. Re-sync all of the local tags in your repo to only reflect the tags on GitHub by running
`git tag | xargs -n1 git tag -d && git fetch --tags` (taken from [this StackOverflow response](http://stackoverflow.com/a/10644209/1509082))
1. Re-run the publish command. Note that the new component versions are saved to `.new-versions.log`
in the repo's root directory, which you can use to re-enter the new versions.

**If something goes wrong while lerna is pushing the published changes / tags to GitHub**:

1. `Ctrl+C` / abort the lerna command.
1. Run `git push && git push --tags`. This does the equivalent of what lerna would have done.

## "What's the core team up to?"

The core team maintains a [public Pivotal Tracker](https://www.pivotaltracker.com/n/projects/1664011) (**tracker** for short) which details all the items we're working on within our current two-week [iteration](https://www.agilealliance.org/glossary/iteration/). This tracker mirrors in what's in our GH issues. It is used _purely for planning and prioritization purposes, **not** for discussions or community issue filing_. That being said, it's a great place to look at the overall state of our project as well as some the big ticket issues we're working on.
Expand Down
9 changes: 4 additions & 5 deletions demos/checkbox.html
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ <h2>With Javascript</h2>
<div class="mdc-form-field">
<div id="mdc-js-checkbox" class="mdc-checkbox">
<input type="checkbox"
id="my-checkbox"
id="native-js-checkbox"
class="mdc-checkbox__native-control"/>
<div class="mdc-checkbox__background">
<svg version="1.1"
Expand All @@ -106,7 +106,7 @@ <h2>With Javascript</h2>

</div>
</div>
<label for="my-checkbox" id="my-checkbox-label">This is my checkbox</label>
<label for="native-js-checkbox" id="my-checkbox-label">This is my checkbox</label>
</div>
<button type="button" id="make-ind">Make indeterminate</button>
</section>
Expand Down Expand Up @@ -144,15 +144,14 @@ <h2>Dark Theme</h2>
var MDCFormField = global.mdc.formField.MDCFormField;

var checkbox = document.getElementById('mdc-js-checkbox');
var checkboxInstance = new MDCCheckbox(document.getElementById('mdc-js-checkbox'));
var checkboxInstance = new MDCCheckbox(checkbox);

var formField = checkbox.parentElement;
var formFieldInstance = new MDCFormField(formField);

formFieldInstance.input = checkboxInstance;

document.getElementById('make-ind').addEventListener('click', function() {
checkbox.indeterminate = true;
checkboxInstance.indeterminate = true;
});
})(this);
</script>
Expand Down
Loading