feat(select): Support synchronizing enhanced select w/ hidden input #3986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfranqueiro
force-pushed
the
feat/select/add-invalid
branch
from
70d9539 to
f261f51
Compare
kfranqueiro
force-pushed
the
feat/select/hidden-input
branch
from
e3bd3d1 to
5d2c3f5
Compare
williamernest
approved these changes
Oct 25, 2018
packages/mdc-select/README.md
Outdated
| >NOTE: The `data-value` attribute is required for the enhanced select. | ||
| > NOTE: The `data-value` attribute is required for each list item in the enhanced select. | ||
|
|
||
| > NOTE: The `input type="hidden"` is optional, and will synchronize the value of the enhanced select for form submissions. |
There was a problem hiding this comment.
Nit: Kind of sounds like type="hidden" is optional and not the whole element. Maybe
The input type="hidden" element is optional, and will ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3729.
Currently comparing against add-invalid branch since I wrote it on top of that.