feat(tab): Implement a ripple color mixin for Tab #4421
Conversation
|
All 624 screenshot tests passed for commit d0db5c3 vs. |
packages/mdc-tab/_mixins.scss
Outdated
| @@ -36,6 +37,17 @@ | |||
| } | |||
| } | |||
|
|
|||
| @mixin mdc-tab-ripple-color($color) { | |||
There was a problem hiding this comment.
Should we call this mdc-tab-states-color given that it's invoking mdc-states?
There was a problem hiding this comment.
That's a good idea.
Just an aside: the mixed naming between "ripple" and "states" keeps tripping me up.
|
Yeah sorry about that. I will update the docs. |
|
All 624 screenshot tests passed for commit 40c4a67 vs. |
|
Added docs for the mixins. |
| } | ||
| } | ||
|
|
||
| @mixin mdc-tab-ink-color($color) { |
There was a problem hiding this comment.
Since this is here... should this also set mdc-tab-icon-color so that everything is set together? (I forget why text and icon color were originally separate, maybe @patrickrodee can weigh in on this.)
There was a problem hiding this comment.
We had separate mixins for text and icon in other components when I added these mixins. Setting icon color in the ink mixin makes sense to me.
There was a problem hiding this comment.
Makes sense, my definition of ink was outdated. Done.
|
All 624 screenshot tests passed for commit 504dbe9 vs. |
|
All 624 screenshot tests passed for commit df208c1 vs. |
|
All 624 screenshot tests passed for commit 5276f45 vs. |
|
All 624 screenshot tests passed for commit ad53d28 vs. |
No description provided.