feat(dialog): Add Foundation#setInitialFocusEl API. #4719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #4719 +/- ##
==========================================
Coverage ? 98.93%
==========================================
Files ? 129
Lines ? 6301
Branches ? 821
==========================================
Hits ? 6234
Misses ? 66
Partials ? 1
Continue to review full report at Codecov.
|
|
All 690 screenshot tests passed for commit f28fb3e vs. |
abhiomkar
reviewed
May 15, 2019
abhiomkar
requested changes
May 15, 2019
|
All 693 screenshot tests passed for commit 6ad2e48 vs. |
abhiomkar
approved these changes
May 16, 2019
|
All 693 screenshot tests passed for commit 0122dcf vs. |
moog16
pushed a commit
that referenced
this pull request
May 28, 2019
Add Adapter#getInitialFocusEl API. initialFocusEl will be the element passed in to Adapter#trapFocus. This formalizes the a11y-aligned idea of adding focus to an initial element (in #trapFocus) into the API. BREAKING CHANGE: Dialog Adapter#getInitialFocusEl has been added and Adapter#trapFocus first argument is now the initialFocusEl.
moog16
pushed a commit
that referenced
this pull request
Jun 3, 2019
Add Adapter#getInitialFocusEl API. initialFocusEl will be the element passed in to Adapter#trapFocus. This formalizes the a11y-aligned idea of adding focus to an initial element (in #trapFocus) into the API. BREAKING CHANGE: Dialog Adapter#getInitialFocusEl has been added and Adapter#trapFocus first argument is now the initialFocusEl.
abhiomkar
pushed a commit
that referenced
this pull request
Jun 11, 2019
Add Adapter#getInitialFocusEl API. initialFocusEl will be the element passed in to Adapter#trapFocus. This formalizes the a11y-aligned idea of adding focus to an initial element (in #trapFocus) into the API. BREAKING CHANGE: Dialog Adapter#getInitialFocusEl has been added and Adapter#trapFocus first argument is now the initialFocusEl.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Foundation#setInitialFocusEl, #getInitialFocusEl API.
initialFocusElwill be the element passed in to Adapter#trapFocus. This formalizes the a11y-aligned idea of adding focus to an initial element (in #trapFocus) into the API.BREAKING CHANGE: Dialog
Foundation#setInitialFocusEl,Foundation#getInitialFocusElhave been added andAdapter#trapFocusfirst argument is now theinitialFocusEl.