Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dialog): Add noflip annotations for GSS compiler. #4769

Merged
merged 16 commits into from
May 29, 2019
Merged

fix(dialog): Add noflip annotations for GSS compiler. #4769

Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
28eff3c
chore: add develop to travis.yml (#4659)
Apr 29, 2019
3fd9ee6
feat(chips): Use semantic button elements (#4627)
patrickrodee Apr 30, 2019
88cc637
refactor(dialog): Split dialog Foundation#handleInteraction into #han…
joyzhong May 2, 2019
e1230bc
docs(dialog): Fix foundation comments. (#4672)
joyzhong May 2, 2019
66816a5
feat(menu): add setSelectedIndex to set selected item in menu selecti…
May 6, 2019
240246e
fix(chips): Fix chips trailing icon margin (#4720)
abhiomkar May 15, 2019
3ddbcd4
feat(checkbox): Added mixin to customize checkbox touch dimension. (#…
abhiomkar May 15, 2019
7ac7e6e
feat(dialog): Add Adapter#getInitialFocusEl. (#4719)
joyzhong May 16, 2019
f9172d0
refactor(top-app-bar): Remove [de]registerEventHandler methods from a…
May 17, 2019
ce365e0
feat(chips): Add setAttr adapter method (#4736)
patrickrodee May 20, 2019
6c045f6
fix(checkbox): screenshot test golden update (#4735)
May 21, 2019
3224490
test: Fix choice chips screenshot test (#4742)
patrickrodee May 22, 2019
17b8339
fix(dialog): Fix scrolling content overflowing on Chrome/Android. (#4…
joyzhong May 28, 2019
6a3c771
fix(dialog): Use 100vw for dialog max-width calculation. (#4766)
joyzhong May 28, 2019
05d8c87
fix(dialog): Add noflip annotations for GSS compiler.
joyzhong May 28, 2019
d5d1e26
Merge remote-tracking branch 'origin/develop' into fix/dialog_rtl
joyzhong May 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/mdc-dialog/_mixins.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@
overflow-y: auto;

@include mdc-rtl(".mdc-dialog") {
/* @noflip */
text-align: right;
}
}
Expand All @@ -128,6 +129,7 @@
border-bottom: 1px solid transparent;

@include mdc-rtl(".mdc-dialog") {
/* @noflip */
text-align: right;
}
}
Expand Down Expand Up @@ -240,9 +242,11 @@

@include mdc-feature-targets($feat-structure) {
max-width: 100%; // Prevent long text from overflowing parent element in IE 11
/* @noflip */
text-align: right;

@include mdc-rtl(".mdc-dialog") {
/* @noflip */
text-align: left;
}
}
Expand Down