Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(list): Interactive list items in RTL get pushed to the left #746

Merged
merged 2 commits into from
May 30, 2017
Merged

fix(list): Interactive list items in RTL get pushed to the left #746

merged 2 commits into from
May 30, 2017

Conversation

robzenn92
Copy link
Contributor

Should fix #725

@traviskaufman
Copy link
Contributor

Thanks for submitting! TravisCI is failing on a lint issue. If you move the @include line up to the top of the declaration and put a line of space after it, it should work.

@robzenn92
Copy link
Contributor Author

Sorry @traviskaufman, I didn't run npm run lint before committing changes. I skipped it cause the fix was easy! 😄 my fault!

traviskaufman
traviskaufman approved these changes May 30, 2017
View reviewed changes
Copy link
Contributor

@traviskaufman traviskaufman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💎 Thank you!

@traviskaufman traviskaufman merged commit ae4e87f into material-components:master May 30, 2017
@codecov-io
Copy link

Codecov Report

Merging #746 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #746   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files          65       65           
  Lines        2767     2767           
  Branches      318      318           
=======================================
  Hits         2765     2765           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e21ec90...baab508. Read the comment docs.

lynnmercier pushed a commit that referenced this pull request Jun 1, 2017
@robzenn92 @lynnmercier
fix(list): Properly position interactive list items in RTL context (#746
00b8524 
)

Fixes #725
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@traviskaufman traviskaufman traviskaufman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Interactive list items in RTL get pushed to the left
3 participants
@robzenn92 @traviskaufman @codecov-io