From cfe604656dbf3661f145390c0dd1d32b48b515ed Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=C3=A1t=C3=A9=20Tokodi?= Date: Thu, 16 May 2024 14:12:29 +0200 Subject: [PATCH] re enable checks job MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit JerryScript-DCO-1.0-Signed-off-by: Máté Tokodi mate.tokodi@szteszoftver.hu --- .github/workflows/gh-actions.yml | 50 +++++++++++----------- jerry-core/ecma/base/ecma-helpers-number.c | 5 +-- jerry-core/ecma/base/ecma-helpers.c | 4 +- jerry-core/ecma/base/ecma-helpers.h | 2 +- 4 files changed, 30 insertions(+), 31 deletions(-) diff --git a/.github/workflows/gh-actions.yml b/.github/workflows/gh-actions.yml index 827a527dc1..b6dc5aafab 100644 --- a/.github/workflows/gh-actions.yml +++ b/.github/workflows/gh-actions.yml @@ -6,31 +6,31 @@ env: RUNNER: tools/run-tests.py jobs: -# Checks: -# runs-on: ubuntu-22.04 # needed for checker version stability -# steps: -# - uses: actions/checkout@v2 -# with: -# fetch-depth: 0 -# - uses: actions/setup-python@v2 -# with: -# python-version: '3.10' -# - run: sudo apt update -# - run: sudo apt install pylint doxygen cppcheck clang-format-15 -# - run: $RUNNER --check-signed-off=gh-actions -# if: ${{ always() }} -# - run: $RUNNER --check-doxygen -# if: ${{ always() }} -# - run: $RUNNER --check-format -# if: ${{ always() }} -# - run: $RUNNER --check-license -# if: ${{ always() }} -# - run: $RUNNER --check-strings -# if: ${{ always() }} -# - run: $RUNNER --check-pylint -# if: ${{ always() }} -# - run: $RUNNER --check-cppcheck -# if: ${{ always() }} + Checks: + runs-on: ubuntu-22.04 # needed for checker version stability + steps: + - uses: actions/checkout@v2 + with: + fetch-depth: 0 + - uses: actions/setup-python@v2 + with: + python-version: '3.10' + - run: sudo apt update + - run: sudo apt install pylint doxygen cppcheck clang-format-15 + - run: $RUNNER --check-signed-off=gh-actions + if: ${{ always() }} + - run: $RUNNER --check-doxygen + if: ${{ always() }} + - run: $RUNNER --check-format + if: ${{ always() }} + - run: $RUNNER --check-license + if: ${{ always() }} + - run: $RUNNER --check-strings + if: ${{ always() }} + - run: $RUNNER --check-pylint + if: ${{ always() }} + - run: $RUNNER --check-cppcheck + if: ${{ always() }} # # Linux_x86-64_Build_Correctness_Debugger_Tests: # runs-on: ubuntu-latest diff --git a/jerry-core/ecma/base/ecma-helpers-number.c b/jerry-core/ecma/base/ecma-helpers-number.c index 43f1f32206..9521261a82 100644 --- a/jerry-core/ecma/base/ecma-helpers-number.c +++ b/jerry-core/ecma/base/ecma-helpers-number.c @@ -350,7 +350,6 @@ ecma_number_trunc (ecma_number_t num) /**< ecma-number */ return ecma_number_from_binary (binary); } /* ecma_number_trunc */ - /** * Calculate remainder of division of two numbers, * as specified in ECMA-262 v5, 11.5.3, item 6. @@ -374,9 +373,9 @@ ecma_number_remainder (ecma_number_t left_num, /**< left operand */ { #ifdef __APPLE__ r = ecma_number_negate (r); -#else +#else /* !__APPLE__ */ r = -r; -#endif +#endif /* __APPLE__ */ } return r; diff --git a/jerry-core/ecma/base/ecma-helpers.c b/jerry-core/ecma/base/ecma-helpers.c index 4bd30d57a1..02fb8e24d8 100644 --- a/jerry-core/ecma/base/ecma-helpers.c +++ b/jerry-core/ecma/base/ecma-helpers.c @@ -1800,8 +1800,8 @@ ecma_number_t JERRY_ATTR_CONST ecma_number_negate (ecma_number_t num) { return -num; -} -#endif +} /* ecma_number_negate */ +#endif /* __APPLE__ */ /** * @} diff --git a/jerry-core/ecma/base/ecma-helpers.h b/jerry-core/ecma/base/ecma-helpers.h index e6c8b4e1e2..7067dbc6e2 100644 --- a/jerry-core/ecma/base/ecma-helpers.h +++ b/jerry-core/ecma/base/ecma-helpers.h @@ -495,7 +495,7 @@ uintptr_t ecma_get_current_stack_usage (void); #endif /* (JERRY_STACK_LIMIT != 0) */ #ifdef __APPLE__ ecma_number_t ecma_number_negate (ecma_number_t num); -#endif +#endif /* __APPLE__ */ /* ecma-helpers-external-pointers.c */ bool ecma_create_native_pointer_property (ecma_object_t *obj_p,