Fixes nested Modules (again)

[poke1024]

Yesterday's fix for nested Modules (#584) was not really correct. I added evaluation to the replace_vars pipeline, which is not a bad thing in itself, I guess. The problem is, though, that Module should not actually evaluate at that point, but only later when it gets to new_expr.evaluate(evaluation). If it evaluates earlier, nested modules get evaluated, which is not what we want. I added this rather funky test case to demonstrate what happens if evaluation happens too early (it calls Abort[]).

[sn6uv]

Should I revert the changes in #584 or are they still needed?

[poke1024]

The changes in #584 are actually not needed. replace_vars will never need an evaluation for this fix.

[sn6uv]

I've reverted e7e51dd but kept the rest.

[mmatera]

I proposed the change because Mathics crashes on my system without it
M

Enviado desde mi teléfono inteligente Sony Xperia™

---- Angus Griffith escribió ----

Should I revert the changes in #584 or are they still needed?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/mathics/Mathics","title":"mathics/Mathics","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/mathics/Mathics"}},"updates":{"snippets":[{"icon":"PERSON","message":"@sn6uv in #591: Should I revert the changes in #584 or are they still needed?"}],"action":{"name":"View Pull Request","url":"https://github.com/mathics/Mathics/pull/591#issuecomment-250035077"}}}