Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #989 #991

Merged
merged 4 commits into from
Oct 26, 2020
Merged

Fix #989 #991

merged 4 commits into from
Oct 26, 2020

Conversation

mmatera
Copy link
Contributor

@mmatera mmatera commented Oct 26, 2020

This is a more elegant way to fix #989 than #990

@mmatera mmatera mentioned this pull request Oct 26, 2020
@rocky
Copy link
Member

rocky commented Oct 26, 2020

I think you have to use mark a lookahead, i.e. (?<= ...) (?=...) somehow.

@mmatera
Copy link
Contributor Author

mmatera commented Oct 26, 2020

You are right! I hope now it works...

@mmatera
Copy link
Contributor Author

mmatera commented Oct 26, 2020

So, the unique thing that deserves revision is the test in the docstring. @rocky, if you agree, I merge this.

@rocky
Copy link
Member

rocky commented Oct 26, 2020

If you ask my opinion, for an example it would need more explanation in the example.

For example to point out that this casually this looks similar to ReplaceAll[] : if /.x were used instead of /.2.

Otherwise I think it would be better done as a test in test/test_evaluation.py because a /.5 == 2 a isn't all that interesting in of itself.

Your choice though.

And feel free to merge whenever you like.

@GarkGarcia GarkGarcia changed the title fix989 Fix #989 Oct 26, 2020
@GarkGarcia GarkGarcia added the bug label Oct 26, 2020
@mmatera mmatera merged commit edbf880 into master Oct 26, 2020
@mmatera mmatera deleted the fix989 branch October 26, 2020 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parser can't differentiate between ReplaceAll and Division (Times [ , Power])
3 participants