Skip to content

Conversation

@dpvc
Copy link
Member

@dpvc dpvc commented Nov 10, 2025

This PR removes the usage of * in CHTML's CSS selectors. Apparently, that is a performance issue in some cases, so these were made specific to the types of nodes that can be contained in the parent node. Some of the more complex ones are constructed from parts.

@dpvc dpvc requested a review from zorkow November 10, 2025 15:07
@dpvc dpvc added this to the v4.1.0 milestone Nov 10, 2025
@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.77%. Comparing base (ec084b0) to head (6494d56).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1387   +/-   ##
========================================
  Coverage    86.76%   86.77%           
========================================
  Files          338      338           
  Lines        84387    84418   +31     
  Branches      4791     4796    +5     
========================================
+ Hits         73220    73251   +31     
+ Misses       11167    11144   -23     
- Partials         0       23   +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

I did not know that * was a performance issue. But DuckAI agrees...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants