Sre v4 Integration #800
Merged
Sre v4 Integration #800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update component files for changes to sre component
…at they can be added before other imports, and so that the combined components work with SRE4. Also, fix sre webpack libs.
Allow SRE to use resolverPath during startup
…into sre4_cleaner_export
…rc into sre4_new_top_component
dpvc
requested changes
May 1, 2022
Member
dpvc
left a comment
dpvc
left a comment
There was a problem hiding this comment.
This looks good, but I think there is an issue with the promise handling in KeyExplorer. See the discussion in the comments to the code.
dpvc
reviewed
May 2, 2022
Member
Author
|
Incorporates review suggestions. PTAL. Note, that this also takes care of the path issue that I had mentioned yesterday. So no need for another PR on this. However, I noticed that when a non-existent locale is provided in the option settings, we get a discrepancy in the context menu. |
dpvc
approved these changes
May 6, 2022
Member
dpvc
left a comment
dpvc
left a comment
There was a problem hiding this comment.
Two small changes requested, but otherwise looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration of new SRE v4. Depends on SRE v4.0.4.
Changes to SRE integration
SRE can now be imported directly via the file given in its distribution. To keep import clean
sre.tsnow imports all API methods and exports them for use elsewhere. Consequently modules depending on SRE only have to importsre.js. Files with old type handling (d.tsfiles) are removed.Changes to the explorer
Most changes are wrt. the new handling of API methods and updating to new locales. The most significant change in logic is that
setupEnginenow returns a promise itself, indicating when locale loading has been complete. Consequently previously awkward constructions withsreReadyare rewritten inexplorer.tsbut also insemantic-enrich.ts.Changes to the components
The component integrating SRE is now build similar to other components:
srecomponent directory takes care the webpacking. Main filesre.jsand configuration insre_config.jssre-nodeandsre-browser.semantic-enrichanda11yinit.jscomponent subsuming thestartup.jscalls implemented by @dpvcNew component
The PR also includes a new exemplary component
tex-chtml-full-speechthat demonstrates how SRE locales can be included viajsonimports in a MathJax distribution. This ensures that MathJax's internalMathMapsmap is usually empty, keeping builds small and also allowing our lab still to work as usual.