From 4271f8e0fd3588547a38bd2cb8a930a66bcb0bdd Mon Sep 17 00:00:00 2001 From: Tim-Hinnerk Heuer Date: Mon, 23 Aug 2021 08:21:59 +1200 Subject: [PATCH] remove acceptedValues from PageUrl (#17895) * remove acceptedValues from PageUrl fixes #15322 * adjust expected in test #15322 --- plugins/Actions/Columns/PageUrl.php | 1 - .../test_apiGetReportMetadata__API.getSegmentsMetadata.xml | 1 - 2 files changed, 2 deletions(-) diff --git a/plugins/Actions/Columns/PageUrl.php b/plugins/Actions/Columns/PageUrl.php index 9040cfb2cba..a79a8cc659b 100644 --- a/plugins/Actions/Columns/PageUrl.php +++ b/plugins/Actions/Columns/PageUrl.php @@ -22,7 +22,6 @@ class PageUrl extends ActionDimension protected $nameSingular = 'Actions_ColumnPageURL'; protected $namePlural = 'Actions_PageUrls'; protected $type = self::TYPE_URL; - protected $acceptValues = 'All these segments must be URL encoded, for example: http%3A%2F%2Fexample.com%2Fpath%2Fpage%3Fquery'; protected $category = 'General_Actions'; protected $sqlFilter = '\\Piwik\\Tracker\\TableLogAction::getIdActionFromSegment'; protected $suggestedValuesApi = 'Actions.getPageUrls'; diff --git a/tests/PHPUnit/System/expected/test_apiGetReportMetadata__API.getSegmentsMetadata.xml b/tests/PHPUnit/System/expected/test_apiGetReportMetadata__API.getSegmentsMetadata.xml index 5abbf967449..5c684f6ae81 100644 --- a/tests/PHPUnit/System/expected/test_apiGetReportMetadata__API.getSegmentsMetadata.xml +++ b/tests/PHPUnit/System/expected/test_apiGetReportMetadata__API.getSegmentsMetadata.xml @@ -680,7 +680,6 @@ Behaviour Page URL pageUrl - All these segments must be URL encoded, for example: http%3A%2F%2Fexample.com%2Fpath%2Fpage%3Fquery dimension