Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MITM options helpers don't compose well #68

Closed
kegsay opened this issue May 23, 2024 · 2 comments · Fixed by #120
Closed

MITM options helpers don't compose well #68

kegsay opened this issue May 23, 2024 · 2 comments · Fixed by #120
Assignees

Comments

@kegsay
Copy link
Member

kegsay commented May 23, 2024

If you want both a callback server and to restrict an endpoint, you need to fallback to WithMITMOptions and cannot use WithSniffedEndpoint. We should make this composable.

@kegsay
Copy link
Member Author

kegsay commented Jun 18, 2024

Also if you want to block requests and listen, and then just drop the blocking, you can't do this currently. You need to take away the blocking and listening then re-add the listening.

@kegsay
Copy link
Member Author

kegsay commented Jul 5, 2024

With #106 this should be possible now, with some rejigging, because everything is now using the callback addon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant