Remove status_code addon #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
reviewed
Jul 5, 2024
richvdh
approved these changes
Jul 5, 2024
tests/mitmproxy_addons/README.md
Outdated
Comment on lines
80
to
81
| response_body: { some json object }, |
There was a problem hiding this comment.
are they necessarily JSON? What if, say, the intercepted request was for a piece of media?
There was a problem hiding this comment.
It has to be JSON currently as I call flow.response.json() to populate response_body. If/when we want to use complement-crypto with media, we can revisit this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use callback addon instead.
Also update README with HTTP API docs for the callback addon.
This obsoletes #8
This fixes #7