This repository has been archived by the owner on Sep 10, 2024. It is now read-only.
Wire up i18n for the React frontend #1962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
f5b096f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://284d9b24.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://t3chguy-i18n.matrix-authentication-service-docs.pages.dev |
sandhose
added
A-Frontend
This has multiple advantages: - the JSON files get hashes - we can preload assets - it loads the assets correctly if the app is mounted somewhere else - we have an explicit list of supported languages created a build time
It turns out that wasn't really needed, the import glob was enough
sandhose
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
TYVM! Pretty happy with this setup :)
I did a few small changes, mainly:
- include the i18next-parser config in the lint/tsc pipeline, so that it gets formatted and typechecked
- load the translations through the vite assets pipeline, not just the public folder, so that they get unique hashes for better caching
One follow up I would like to do is to integrate a language picker in Storybook (which is broken right now but I'll fix in another PR)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.