what does a push rule tweak of sound with no value do?

[richvdh]

What happens if I add an action of {"set_tweak": "sound"} (with no value) to a push rule? Is it rejected by the server? is it the same as value: default? or the same as not setting the tweak at all?

[richvdh]

Synapse certainly seems to allow it. As per matrix-org/sygnal#107, sygnal no longer cares about the sound tweak, and the behaviour is determined by the client.

[richvdh]

riot-web doesn't care about the value: https://github.com/matrix-org/matrix-react-sdk/blob/227fc24d3aedba79a30eaf3963a9e9e8fefcba2a/src/Notifier.js#L374

[t3chguy]

though if value was null then riot-web would not play audio https://github.com/matrix-org/matrix-js-sdk/blob/be05452c7031a1d2f2dfdaeca153808665763c83/src/pushprocessor.js#L407-L410

[richvdh]

riotX treats it the same as {"set_tweak": "sound", "value": "default"}. riot-iOS, on the other hand, will ignore the tweak if no value is given: https://github.com/vector-im/riot-ios/blob/e4cd215e1b4e8f3e9a41961ff0ee6290b8588423/Riot/Managers/PushNotification/PushNotificationService.m#L572-L576.