-
-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change _unstable_getSharedRooms
to _unstable_getMutualRooms
#2271
Change _unstable_getSharedRooms
to _unstable_getMutualRooms
#2271
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2271 +/- ##
===========================================
- Coverage 58.96% 58.95% -0.02%
===========================================
Files 91 91
Lines 16326 16329 +3
Branches 3766 3767 +1
===========================================
Hits 9627 9627
- Misses 6699 6702 +3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note also that this sort of rename is not required in order for the MSC to pass the implementation check. The name of the feature is less important than the function of it.
(Synapse (re)implementation will happen concurrently) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
In accordance with changes to matrix-org/matrix-spec-proposals#2666, renaming from "shared" to "mutual".
This updates #1417
This blocks matrix-org/matrix-react-sdk#4897
Notes: Change
_unstable_getSharedRooms
to_unstable_getMutualRooms
and update unstable URL.Type: task
Signed-off-by: Jonathan de Jong <jonathan@automatia.nl>
This change is marked as an internal change (Task), so will not be included in the changelog.