Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unit test paginating /notifications #3283

Merged
merged 2 commits into from
Apr 16, 2023
Merged

unit test paginating /notifications #3283

merged 2 commits into from
Apr 16, 2023

Conversation

kerryarchibald
Copy link
Contributor

@kerryarchibald kerryarchibald commented Apr 14, 2023 •
edited by github-actions bot
Loading

element-hq/element-web#24927

Unit test paginateEventTimeline with notifications timeline before changing it

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@kerryarchibald kerryarchibald added the T-Task Tasks for the team like planning label Apr 14, 2023
@kerryarchibald kerryarchibald marked this pull request as ready for review April 14, 2023 05:30
@kerryarchibald kerryarchibald requested a review from a team as a code owner April 14, 2023 05:30
@kerryarchibald kerryarchibald mentioned this pull request Apr 14, 2023
Merged
3 tasks
@kerryarchibald kerryarchibald added this pull request to the merge queue Apr 16, 2023
Merged via the queue into develop with commit d40d5c8 Apr 16, 2023
@kerryarchibald kerryarchibald deleted the kerry/24927/test-notifications-fetch branch April 16, 2023 22:45
texuf pushed a commit to texuf/matrix-js-sdk that referenced this pull request Apr 17, 2023
@texuf
unit test paginating /notifications (matrix-org#3283)
2cc1c28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justjanne justjanne justjanne approved these changes

@robintown robintown Awaiting requested review from robintown robintown is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kerryarchibald @justjanne