Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up code for handling decryption failures #4126

Merged
merged 11 commits into from
Mar 22, 2024
Merged

Clean up code for handling decryption failures #4126

merged 11 commits into from
Mar 22, 2024

Commits on Mar 21, 2024

  1. Remove redundant check for crypto 

    This is unreachable with `crypto` unset. That's enforced by the types. If you
call it with an unset `crypto`, you deserve a TypeError.
    @richvdh
    richvdh committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    e467a89 View commit details
    Browse the repository at this point in the history

  2. Simplify flow in decryptionLoop

    @richvdh
    richvdh committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    79197ef View commit details
    Browse the repository at this point in the history

  3. Remove now-unused `EventDecryptionResult.encryptedDisabledForUnverifi… 

    …edDevices`
    @richvdh
    richvdh committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    6068c94 View commit details
    Browse the repository at this point in the history

  4. Use an enum for decryption failure reasons

    @richvdh
    richvdh committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    4f867c6 View commit details
    Browse the repository at this point in the history

  5. Stash decryption failure reason in Event

    @richvdh
    richvdh committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    7ab1ff0 View commit details
    Browse the repository at this point in the history

  6. isDecryptionFailure: use _decryptionFailureReason 

    This should be more reliable, and more efficient, than checking the message
type.
    @richvdh
    richvdh committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    3d6677c View commit details
    Browse the repository at this point in the history

  7. Move DecryptionError to common-crypto

    @richvdh
    richvdh committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    c2a9b17 View commit details
    Browse the repository at this point in the history

  8. Advise against use of err param of Decrypted event

    @richvdh
    richvdh committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    45cdd22 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2024

  1. Merge remote-tracking branch 'origin/develop' into rav/historical_eve… 

    …nts/00_prep
    @richvdh
    richvdh committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    fe427b6 View commit details
    Browse the repository at this point in the history

  2. Use DecryptionFailureCode in new test helper

    @richvdh
    richvdh committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    75091f7 View commit details
    Browse the repository at this point in the history

  3. update tests

    @richvdh
    richvdh committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    1c64011 View commit details
    Browse the repository at this point in the history