Quick settings: Change the copy / labels on the options (#10427)

* Quick settings: Change the copy / labels on the options * Update i18n
matrix-org · Apr 4, 2023 · 52eec28 · 52eec28
1 parent a340387
commit 52eec28
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/cypress/e2e/sliding-sync/sliding-sync.ts b/cypress/e2e/sliding-sync/sliding-sync.ts
@@ -202,7 +202,7 @@ describe("Sliding Sync", () => {
 
         // disable notifs in this room (TODO: CS API call?)
         cy.contains(".mx_RoomTile", "Test Room").find(".mx_RoomTile_notificationsButton").click({ force: true });
-        cy.contains("Off").click();
+        cy.contains("Mute room").click();
 
         // create a new room so we know when the message has been received as it'll re-shuffle the room list
         cy.createRoom({

diff --git a/src/components/views/context_menus/RoomNotificationContextMenu.tsx b/src/components/views/context_menus/RoomNotificationContextMenu.tsx
@@ -52,7 +52,7 @@ export const RoomNotificationContextMenu: React.FC<IProps> = ({ room, onFinished
 
     const defaultOption: JSX.Element = (
         <IconizedContextMenuRadio
-            label={_t("Use default")}
+            label={_t("Match default setting")}
             active={notificationState === RoomNotifState.AllMessages}
             iconClassName="mx_RoomNotificationContextMenu_iconBell"
             onClick={wrapHandler(() => setNotificationState(RoomNotifState.AllMessages))}
@@ -70,7 +70,7 @@ export const RoomNotificationContextMenu: React.FC<IProps> = ({ room, onFinished
 
     const mentionsOption: JSX.Element = (
         <IconizedContextMenuRadio
-            label={_t("Mentions & Keywords")}
+            label={_t("Mentions & keywords")}
             active={notificationState === RoomNotifState.MentionsOnly}
             iconClassName="mx_RoomNotificationContextMenu_iconBellMentions"
             onClick={wrapHandler(() => setNotificationState(RoomNotifState.MentionsOnly))}
@@ -79,7 +79,7 @@ export const RoomNotificationContextMenu: React.FC<IProps> = ({ room, onFinished
 
     const muteOption: JSX.Element = (
         <IconizedContextMenuRadio
-            label={_t("Off")}
+            label={_t("Mute room")}
             active={notificationState === RoomNotifState.Mute}
             iconClassName="mx_RoomNotificationContextMenu_iconBellCrossed"
             onClick={wrapHandler(() => setNotificationState(RoomNotifState.Mute))}

diff --git a/src/i18n/strings/en_EN.json b/src/i18n/strings/en_EN.json
@@ -3255,8 +3255,8 @@
     "Low Priority": "Low Priority",
     "Forget Room": "Forget Room",
     "Mark as read": "Mark as read",
-    "Use default": "Use default",
-    "Mentions & Keywords": "Mentions & Keywords",
+    "Match default setting": "Match default setting",
+    "Mute room": "Mute room",
     "See room timeline (devtools)": "See room timeline (devtools)",
     "Space": "Space",
     "Space home": "Space home",