Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Cleanup pre MSC3773 thread unread notif logic #10023

Merged
merged 2 commits into from
Jan 31, 2023

Conversation

germain-gg
Copy link
Contributor

@germain-gg germain-gg commented Jan 30, 2023

A lot of logic regarding servers that are not supporting thread notifications (pre MSC3773) exists, this PR removes some of it.

Requires matrix-org/matrix-js-sdk#3115

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@germain-gg germain-gg added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Jan 30, 2023
@germain-gg germain-gg force-pushed the gsouquet/deprecate-thread-clientnotifications branch from 20dfe86 to 411431c Compare January 30, 2023 17:34
@germain-gg germain-gg marked this pull request as ready for review January 30, 2023 17:55
@germain-gg germain-gg requested a review from a team as a code owner January 30, 2023 17:55
Copy link
Contributor

@SimonBrandner SimonBrandner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane

@germain-gg germain-gg merged commit 703587b into develop Jan 31, 2023
@germain-gg germain-gg deleted the gsouquet/deprecate-thread-clientnotifications branch January 31, 2023 16:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants