Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Update timeline.spec.ts #10540

Merged
merged 2 commits into from
Apr 11, 2023
Merged

Update timeline.spec.ts #10540

merged 2 commits into from
Apr 11, 2023

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Apr 7, 2023 •
edited
Loading

This PR intends to update timeline.spec.ts by replacing custom commands and using findBy* type queries such as findByText.

For element-hq/element-web#25058

type: task

Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@github-actions github-actions bot added Z-Community-PR Issue is solved by a community member's PR T-Task Refactoring, enabling or disabling functionality, other engineering tasks labels Apr 7, 2023
@luixxiul luixxiul changed the title timeline.spec.ts - deprecate custom commands of find.ts Update timeline.spec.ts - deprecate custom commands of find.ts Apr 7, 2023
@luixxiul luixxiul changed the title Update timeline.spec.ts - deprecate custom commands of find.ts Update timeline.spec.ts - deprecate custom commands Apr 7, 2023
@luixxiul luixxiul changed the title Update timeline.spec.ts - deprecate custom commands Update timeline.spec.ts Apr 8, 2023
luixxiul added 2 commits April 11, 2023 18:31
@luixxiul
timeline.spec.ts - deprecate custom commands of find.ts
f6b035d 
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
@luixxiul
Iterate
9972aa2 
- clickButtonReply()
- findByText()

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
@luixxiul luixxiul mentioned this pull request Apr 11, 2023
Closed
36 tasks
@luixxiul luixxiul marked this pull request as ready for review April 11, 2023 09:46
@luixxiul luixxiul requested a review from a team as a code owner April 11, 2023 09:46
@luixxiul
Copy link
Contributor Author

luixxiul commented Apr 11, 2023 •
edited
Loading

CC @weeman1337, if you have time.

@t3chguy t3chguy enabled auto-merge April 11, 2023 09:50
@luixxiul
Copy link
Contributor Author

@t3chguy Thanks for reviewing!

@t3chguy t3chguy added this pull request to the merge queue Apr 11, 2023
@t3chguy
Copy link
Member

t3chguy commented Apr 11, 2023

@luixxiul no problem, thanks for your continued contributions!

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 11, 2023
@t3chguy t3chguy added this pull request to the merge queue Apr 11, 2023
Merged via the queue into matrix-org:develop with commit 65f6059 Apr 11, 2023
@luixxiul luixxiul deleted the test-timeline branch April 11, 2023 11:08
@luixxiul luixxiul mentioned this pull request Apr 11, 2023
Closed
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@t3chguy t3chguy t3chguy approved these changes

@florianduros florianduros Awaiting requested review from florianduros florianduros is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luixxiul @t3chguy