Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Update get-openid-token.spec.ts - use Cypress Testing Library #10586

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Update get-openid-token.spec.ts - use Cypress Testing Library #10586

merged 1 commit into from
Apr 13, 2023

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Apr 12, 2023 •
edited
Loading

For element-hq/element-web#25033

This PR intends to update get-openid-token.spec.ts by using Cypress Testing Library.

type: task

Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@github-actions github-actions bot added Z-Community-PR Issue is solved by a community member's PR T-Task Refactoring, enabling or disabling functionality, other engineering tasks labels Apr 12, 2023
@luixxiul luixxiul mentioned this pull request Apr 12, 2023
Closed
36 tasks
@luixxiul
Update get-openid-token.spec.ts - use Cypress Testing Library
2bd2d75 
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
@luixxiul luixxiul marked this pull request as ready for review April 13, 2023 03:58
@luixxiul luixxiul requested a review from a team as a code owner April 13, 2023 03:58
@luixxiul luixxiul requested review from richvdh and t3chguy April 13, 2023 03:58
richvdh
richvdh approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@richvdh richvdh added this pull request to the merge queue Apr 13, 2023
Merged via the queue into matrix-org:develop with commit a2c2c01 Apr 13, 2023
@luixxiul luixxiul deleted the test-integration-get-openid-token branch April 13, 2023 07:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@richvdh richvdh richvdh approved these changes

@t3chguy t3chguy Awaiting requested review from t3chguy t3chguy is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luixxiul @richvdh