Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Update sliding-sync.spec.ts - use Cypress Testing Library #10618

Merged
merged 11 commits into from
Apr 21, 2023
Merged

Update sliding-sync.spec.ts - use Cypress Testing Library #10618

merged 11 commits into from
Apr 21, 2023

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Apr 15, 2023 •
edited by github-actions bot
Loading

For element-hq/element-web#25033

This PR intends to update sliding-sync.spec.ts by:

  • using Cypress Testing Library
  • changing the test rooms name from Join, Reject and Rescind to Room to Join, Room to Reject and Room to Rescind, respectively, as findByRole() this PR is going to add is used to search buttons as well, whose label texts are same as the rooms name. This change intends to avoid confusion due to the similarity (to avoid something like this: "Invite" button to search the room "Invite", etc.)

type: task

Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

luixxiul added 6 commits April 15, 2023 09:58
@luixxiul
Update sliding-sync.spec.ts - use Cypress Testing Library
6943344 
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
@luixxiul
Use findByRole() - group, treeitem
9c86e6f 
The elements with ARIA "treeitem" role resides in ones with ARIA "group" role such as Favourites, People, and Invites. The elements with the "treeitem" role correspond to rooms on the room list.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
@luixxiul
Use the library more - 'should render the Rooms list in reverse chron…
f97e6c1 
…ological order by default and allowing sorting A-Z'

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
@luixxiul
Use cy.findAllByRole("treeitem")
b80128e 
Note the Test room is excluded from being counted thanks to within().

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
@luixxiul
Rename the rooms to avoid confusion
b4710d2 
Since it has been unclear "Join" etc. is a verb or a room name, the room
names are changed as below:

- Join -> Room to Join
- Reject -> Room to Reject (the invite)
- Rescind -> Room to Rescind (the invite)

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
@luixxiul
Specify ARIA label for the room sublist headers
193a47d 
Have different ARIA labels specified for "mx_RoomSublist" and "mx_RoomSublist_headerContainer" to clarify the structure.

Change the test to check the new ARIA label.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
@github-actions github-actions bot added Z-Community-PR Issue is solved by a community member's PR T-Task Refactoring, enabling or disabling functionality, other engineering tasks labels Apr 15, 2023
@luixxiul luixxiul mentioned this pull request Apr 15, 2023
Closed
36 tasks
@luixxiul
lint
fb01800 
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
@luixxiul
Fix a race condition
1e6f23b 
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
@luixxiul luixxiul marked this pull request as ready for review April 15, 2023 11:34
@luixxiul luixxiul requested a review from a team as a code owner April 15, 2023 11:34
@luixxiul luixxiul requested review from dbkr and artcodespace April 15, 2023 11:34
@dbkr
Copy link
Member

dbkr commented Apr 17, 2023

I'm no ARIA expert, but it would seem more logical to me to just have one element with the appropriate aria label rather than the header explicitly having a label saying that it's the header?

@luixxiul
Copy link
Contributor Author

I'm sorry, but I am not quite sure either... At first, I am going to update the test by not touching ARIA related stuff, leaving comments / creating an issue about it.

luixxiul added 2 commits April 20, 2023 09:59
@luixxiul
Revert "Specify ARIA label for the room sublist headers"
32c848a 
This reverts commit 193a47d.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
@luixxiul
Merge branch 'develop' into test-sliding-sync
82b617b
@luixxiul
Fix realHover() target
2e1a3c1 
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
@luixxiul
Copy link
Contributor Author

@dbkr The change on ARIA stuff has been reverted. Would you kindly review again?

@luixxiul luixxiul changed the title Update sliding-sync.spec.ts - use Cypress Testing Library and change ARIA label attribute Update sliding-sync.spec.ts - use Cypress Testing Library Apr 20, 2023
@artcodespace artcodespace removed their request for review April 20, 2023 14:53
dbkr
dbkr approved these changes Apr 21, 2023
View reviewed changes
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks very much!

@dbkr dbkr added this pull request to the merge queue Apr 21, 2023
Merged via the queue into matrix-org:develop with commit 05ef1d5 Apr 21, 2023
@luixxiul
Copy link
Contributor Author

Thanks for the review!

@luixxiul luixxiul deleted the test-sliding-sync branch April 21, 2023 10:17
@richvdh richvdh mentioned this pull request May 23, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dbkr dbkr dbkr approved these changes

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luixxiul @dbkr