This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 831
Avoid using markAsRead where we don't need it #11517
Merged
andybalaam
merged 2 commits into
develop
from
andybalaam/avoid-mark-as-read-to-make-tests-pass
Sep 8, 2023
Merged
Avoid using markAsRead where we don't need it #11517
andybalaam
merged 2 commits into
develop
from
andybalaam/avoid-mark-as-read-to-make-tests-pass
Sep 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andybalaam
added
the
T-Task
Refactoring, enabling or disabling functionality, other engineering tasks
label
Sep 1, 2023
andybalaam
force-pushed
the
andybalaam/avoid-mark-as-read-to-make-tests-pass
branch
from
September 5, 2023 10:39
533eff1
to
5d5d3e1
Compare
Even when I use Chromium to run locally, the test "Editing a message makes a room unread" passes for me here, and fails on CI because it can't find the "1" in the notification - instead it finds an empty string:
I am at a loss as to what causes this difference. |
andybalaam
force-pushed
the
andybalaam/avoid-mark-as-read-to-make-tests-pass
branch
from
September 6, 2023 12:14
db49626
to
91b0e43
Compare
andybalaam
force-pushed
the
andybalaam/avoid-mark-as-read-to-make-tests-pass
branch
from
September 8, 2023 04:43
91b0e43
to
e70c03c
Compare
t3chguy
approved these changes
Sep 8, 2023
weeman1337
reviewed
Sep 8, 2023
weeman1337
approved these changes
Sep 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go 👍
andybalaam
deleted the
andybalaam/avoid-mark-as-read-to-make-tests-pass
branch
September 8, 2023 17:12
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid using markAsRead where we don't need it, which allows us to re-enable some disabled tests.
Part of element-hq/element-web#25449
This change is marked as an internal change (Task), so will not be included in the changelog.