Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Avoid using markAsRead where we don't need it #11517

Merged

Conversation

andybalaam
Copy link
Member

@andybalaam andybalaam commented Sep 1, 2023

Avoid using markAsRead where we don't need it, which allows us to re-enable some disabled tests.

Part of element-hq/element-web#25449


This change is marked as an internal change (Task), so will not be included in the changelog.

@andybalaam andybalaam added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Sep 1, 2023
Base automatically changed from andybalaam/just-fix-edit to develop September 4, 2023 16:58
@andybalaam andybalaam force-pushed the andybalaam/avoid-mark-as-read-to-make-tests-pass branch from 533eff1 to 5d5d3e1 Compare September 5, 2023 10:39
@andybalaam
Copy link
Member Author

andybalaam commented Sep 5, 2023

Even when I use Chromium to run locally, the test "Editing a message makes a room unread" passes for me here, and fails on CI because it can't find the "1" in the notification - instead it finds an empty string:

2023-09-05T11:01:27.4619919Z �[32m              cy:log ✱ �[39m Assert room unread Room Beta 1
2023-09-05T11:01:27.4620110Z �[32m          cy:command ✔ �[39m within	
2023-09-05T11:01:27.4620386Z �[31m�[1m          cy:command ✘ �[22m�[39m get	.mx_NotificationBadge_count
2023-09-05T11:01:27.4620978Z �[31m�[1m          cy:command ✘ �[22m�[39m assert	expected **.mx_NotificationBadge_count** to have text **'1'**, but the text was **''**

I am at a loss as to what causes this difference.

@andybalaam andybalaam force-pushed the andybalaam/avoid-mark-as-read-to-make-tests-pass branch from 91b0e43 to e70c03c Compare September 8, 2023 04:43
@andybalaam andybalaam marked this pull request as ready for review September 8, 2023 08:45
@andybalaam andybalaam requested a review from a team as a code owner September 8, 2023 08:45
Copy link
Contributor

@weeman1337 weeman1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go 👍

@andybalaam andybalaam added this pull request to the merge queue Sep 8, 2023
Merged via the queue into develop with commit a4b8616 Sep 8, 2023
19 checks passed
@andybalaam andybalaam deleted the andybalaam/avoid-mark-as-read-to-make-tests-pass branch September 8, 2023 17:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants