This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 831
Fix flaky tests around editing messages #11652
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andybalaam
added
the
T-Task
Refactoring, enabling or disabling functionality, other engineering tasks
label
Sep 22, 2023
Ironically struggling with flaky tests in the PR :-( |
andybalaam
requested review from
SimonBrandner and
robintown
and removed request for
a team
September 22, 2023 10:42
andybalaam
changed the title
Fix flaky test that assumes edits count as messages
Fix flaky tests around editing messages
Sep 22, 2023
Base automatically changed from
andybalaam/split-receipt-tests-into-4
to
develop
September 22, 2023 14:07
robintown
approved these changes
Sep 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I skimmed through the part where the tests were split into multiple files, but looks fine I think
andybalaam
force-pushed
the
andybalaam/fix-flake-in-editing-test
branch
from
September 25, 2023 08:52
9b5b3e9
to
25a462a
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 25, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 25, 2023
3 tasks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 25, 2023
Force-merged since it kept getting kicked out of the merge queue by other flakes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of element-hq/element-web#25449
This change is marked as an internal change (Task), so will not be included in the changelog.