Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fix flaky tests around editing messages #11652

Merged
merged 3 commits into from
Sep 25, 2023

Conversation

andybalaam
Copy link
Member

@andybalaam andybalaam commented Sep 22, 2023

Part of element-hq/element-web#25449


This change is marked as an internal change (Task), so will not be included in the changelog.

@andybalaam andybalaam added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Sep 22, 2023
@andybalaam
Copy link
Member Author

Ironically struggling with flaky tests in the PR :-(

@andybalaam andybalaam marked this pull request as ready for review September 22, 2023 10:42
@andybalaam andybalaam requested a review from a team as a code owner September 22, 2023 10:42
@andybalaam andybalaam requested review from SimonBrandner and robintown and removed request for a team September 22, 2023 10:42
@andybalaam andybalaam changed the title Fix flaky test that assumes edits count as messages Fix flaky tests around editing messages Sep 22, 2023
Base automatically changed from andybalaam/split-receipt-tests-into-4 to develop September 22, 2023 14:07
Copy link
Member

@robintown robintown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I skimmed through the part where the tests were split into multiple files, but looks fine I think

@robintown robintown removed the request for review from SimonBrandner September 22, 2023 17:37
@andybalaam andybalaam force-pushed the andybalaam/fix-flake-in-editing-test branch from 9b5b3e9 to 25a462a Compare September 25, 2023 08:52
@andybalaam andybalaam added this pull request to the merge queue Sep 25, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 25, 2023
@andybalaam andybalaam added this pull request to the merge queue Sep 25, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 25, 2023
@andybalaam andybalaam added this pull request to the merge queue Sep 25, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 25, 2023
@andybalaam andybalaam merged commit 5901920 into develop Sep 25, 2023
19 checks passed
@andybalaam andybalaam deleted the andybalaam/fix-flake-in-editing-test branch September 25, 2023 11:53
@andybalaam
Copy link
Member Author

Force-merged since it kept getting kicked out of the merge queue by other flakes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants