This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Rewrite doesRoomOrThreadHaveUnreadMessages to use the receipt rewrite from js-sdk #11903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andybalaam
added
the
T-Defect
|
Cypress failure: "Spaces > should render subspaces in the space panel only when expanded" (rust and legacy encryption) Jest failure: " EditWysiwygComposer › Should not render the component when not ready" Both of these are unrelated to this PR, and being worked on I think. So we're looking good! |
andybalaam
force-pushed
the
andybalaam/rewrite-receipts2
branch
from
18cbc5e
to
3f806a8
Compare
Previously, if we found a receipt for an unknown event, we would use the receipt timestamp and declare all events before that time to be read. Now, we ignore such "dangling" receipts until we find the event they refer to. This new behaviour is more correct, but does lead to more messages being considered unread. This commit deletes tests that checked for the old behaviour.
|
This now passes all tests but our manual testing suggests it has problems, so @florianduros and I are working to debug. |
dbkr
approved these changes
Nov 27, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of element-hq/element-web#24392
Depends on matrix-org/matrix-js-sdk#3901
Here's what your changelog entry will look like:
🐛 Bug Fixes