This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Make lint warnings more visible in the hopes that they will be fixed #2215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aaron Raimist <aaron@raim.ist>
|
Oh and I guess --max-warnings will have to be changed/removed temporarily if this is merged |
Signed-off-by: Aaron Raimist <aaron@raim.ist>
aaronraimist
force-pushed
the
more-visible-warnings
branch
from
535f91b to
a5f9694
Compare
|
I'm going to go ahead and close this for now since it isn't super important |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not a huge priority because this is just going to create more work for other people. Feel free to put this on hold.
From element-hq/element-web#7490 (comment)
This makes 247 warnings more visible (out of the 528 that exist). I'll look in to fixing some of the easily fixable errors that will make even more warnings visible in a future PR.