diff --git a/src/components/structures/TabbedView.js b/src/components/structures/TabbedView.js index da0ae62e156..6ececbb329c 100644 --- a/src/components/structures/TabbedView.js +++ b/src/components/structures/TabbedView.js @@ -82,12 +82,19 @@ export class TabbedView extends React.Component { const onClickHandler = () => this._setActiveTab(tab); + const label = _t(tab.label); return ( - + {tabIcon} - {_t(tab.label)} + { label } ); diff --git a/src/components/views/dialogs/BaseDialog.js b/src/components/views/dialogs/BaseDialog.js index 65b89d16312..d83ce463607 100644 --- a/src/components/views/dialogs/BaseDialog.js +++ b/src/components/views/dialogs/BaseDialog.js @@ -26,6 +26,7 @@ import { MatrixClient } from 'matrix-js-sdk'; import { KeyCode } from '../../../Keyboard'; import AccessibleButton from '../elements/AccessibleButton'; import MatrixClientPeg from '../../../MatrixClientPeg'; +import { _t } from "../../../languageHandler"; /** * Basic container for modal dialogs. @@ -114,8 +115,9 @@ export default createReactClass({ render: function() { let cancelButton; if (this.props.hasCancel) { - cancelButton = - ; + cancelButton = ( + + ); } return ( diff --git a/src/components/views/elements/AccessibleButton.js b/src/components/views/elements/AccessibleButton.js index 06c440c54e9..a43e2ff26ac 100644 --- a/src/components/views/elements/AccessibleButton.js +++ b/src/components/views/elements/AccessibleButton.js @@ -69,8 +69,7 @@ export default function AccessibleButton(props) { restProps.tabIndex = restProps.tabIndex || "0"; restProps.role = "button"; - restProps.className = (restProps.className ? restProps.className + " " : "") + - "mx_AccessibleButton"; + restProps.className = (restProps.className ? restProps.className + " " : "") + "mx_AccessibleButton"; if (kind) { // We apply a hasKind class to maintain backwards compatibility with @@ -80,6 +79,7 @@ export default function AccessibleButton(props) { if (disabled) { restProps.className += " mx_AccessibleButton_disabled"; + restProps["aria-disabled"] = true; } return React.createElement(element, restProps, children); diff --git a/src/components/views/elements/LabelledToggleSwitch.js b/src/components/views/elements/LabelledToggleSwitch.js index 0cb9b224cf8..ecd4d39bf87 100644 --- a/src/components/views/elements/LabelledToggleSwitch.js +++ b/src/components/views/elements/LabelledToggleSwitch.js @@ -42,7 +42,7 @@ export default class LabelledToggleSwitch extends React.Component { let firstPart = {this.props.label}; let secondPart = ; + onChange={this.props.onChange} aria-label={this.props.label} />; if (this.props.toggleInFront) { const temp = firstPart; diff --git a/src/components/views/elements/SettingsFlag.js b/src/components/views/elements/SettingsFlag.js index a26646b08ce..e4df15a096b 100644 --- a/src/components/views/elements/SettingsFlag.js +++ b/src/components/views/elements/SettingsFlag.js @@ -78,7 +78,7 @@ module.exports = createReactClass({ return (
{label} - +
); }, diff --git a/src/components/views/elements/ToggleSwitch.js b/src/components/views/elements/ToggleSwitch.js index 0d8b3d042ff..e8e870edd84 100644 --- a/src/components/views/elements/ToggleSwitch.js +++ b/src/components/views/elements/ToggleSwitch.js @@ -58,13 +58,24 @@ export default class ToggleSwitch extends React.Component { }; render() { + // eslint-disable-next-line no-unused-vars + const {checked, disabled, onChange, ...props} = this.props; + const classes = classNames({ "mx_ToggleSwitch": true, "mx_ToggleSwitch_on": this.state.checked, "mx_ToggleSwitch_enabled": !this.props.disabled, }); return ( -
+
); diff --git a/src/i18n/strings/en_EN.json b/src/i18n/strings/en_EN.json index 49302fece11..c23cd6d324d 100644 --- a/src/i18n/strings/en_EN.json +++ b/src/i18n/strings/en_EN.json @@ -1211,6 +1211,7 @@ "Unable to find profiles for the Matrix IDs listed below - would you like to invite them anyway?": "Unable to find profiles for the Matrix IDs listed below - would you like to invite them anyway?", "Invite anyway and never warn me again": "Invite anyway and never warn me again", "Invite anyway": "Invite anyway", + "Close dialog": "Close dialog", "Please tell us what went wrong or, better, create a GitHub issue that describes the problem.": "Please tell us what went wrong or, better, create a GitHub issue that describes the problem.", "Preparing to send logs": "Preparing to send logs", "Logs sent": "Logs sent",