Update autocomplete design and scroll it correctly

[aviraldg]

Implements most of element-hq/element-web#1761

[matrixbot]

Can one of the admins verify this patch?

[dbkr]

Given the superclass function here is taking the array and putting it in a div wrapper, the inheritance here seems a bit redundant, since it's doing this wrapping for the overridden function to clone it, add a class, return that and throw the original away.

[aviraldg]

I would agree, in the context that it's a bit of unnecessary OOPism. I do
admit I wrote it this way expecting it would be required later. (If there's
a base structure and each layout needs to customise it a bit.)

On Wed 17 Aug, 2016, 7:26 PM David Baker, notifications@github.com wrote:

In src/autocomplete/CommandProvider.js
#419 (comment)
:

@@ -83,4 +83,10 @@ export default class CommandProvider extends AutocompleteProvider {

     return instance;
 }

• renderCompletions(completions: [React.Component]): ?React.Component {

•    return React.cloneElement(super.renderCompletions(completions), {
  

•        className: 'mx_Autocomplete_Completion_container_block',
  

•    });
  

• }

Given the superclass function here is taking the array and putting it in a
div wrapper, the inheritance here seems a bit redundant, since it's doing
this wrapping for the overridden function to clone it, add a class, return
that and throw the original away.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/matrix-org/matrix-react-sdk/pull/419/files/e1739008089fdc97d4c21fb7039382764f2e92b2#r75127209,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAOlRCseayDyFTzE96zslfUvGhmmQqsmks5qgxMagaJpZM4JmX4X
.

[dbkr]

@matrixbot test this please

[aviraldg]

@dbkr I've extracted the inline styling here and cleaned up the other bits. Should be good to go.

[ara4n]

lgtm