This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Add some media queries to improve UI on mobile (#3991) #4656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TitanNano Thanks for looking at this! Could you include some screenshots of the areas that are changed? I think that would make it easier for us to proceed here. |
TitanNano
commented
Jun 2, 2020
res/css/views/auth/_AuthBody.scss
Outdated
Comment on lines
150
to
157
| @media only screen and (max-width: 480px) { | ||
| .mx_AuthBody { | ||
| width: auto; | ||
| max-width: 500px; | ||
| padding: 10px; | ||
| } | ||
| } |
TitanNano
commented
Jun 2, 2020
Comment on lines
+25
to
+29
| @media only screen and (max-width: 480px) { | ||
| .mx_AuthHeader { | ||
| display: none; | ||
| } | ||
| } |
There was a problem hiding this comment.
Before:
After:
With .mx_AuthBody:
TitanNano
commented
Jun 2, 2020
Comment on lines
+27
to
+31
| @media only screen and (max-width: 480px) { | ||
| .mx_AuthHeaderLogo { | ||
| display: none; | ||
| } | ||
| } |
TitanNano
commented
Jun 2, 2020
Comment on lines
+32
to
+37
|
|
||
| @media only screen and (max-width: 480px) { | ||
| .mx_AuthPage_modal { | ||
| margin-top: 0; | ||
| } | ||
| } |
TitanNano
commented
Jun 2, 2020
Comment on lines
+576
to
+585
| @media only screen and (max-width: 480px) { | ||
| .mx_EventTile_line, .mx_EventTile_reply { | ||
| padding-left: 0; | ||
| margin-right: 0; | ||
| } | ||
| .mx_EventTile_content { | ||
| margin-top: 10px; | ||
| margin-right: 0; | ||
| } | ||
| } |
TitanNano
commented
Jun 2, 2020
Comment on lines
+271
to
+278
| @media only screen and (max-width: 480px) { | ||
| .mx_RoomHeader_wrapper { | ||
| padding: 0; | ||
| } | ||
| .mx_RoomHeader { | ||
| overflow: hidden; | ||
| } | ||
| } |
|
@jryans I added screenshots to each change. |
jryans
suggested changes
Jun 4, 2020
@jryans did you mark what needs to be changed? I'm failing to find it. 😄 |
jryans
reviewed
Jun 9, 2020
|
@TitanNano Sorry, I guess GH ate my comment or I forgot to save it... 😖 Anyway, hopefully it's clear now! |
Signed-off-by: Jovan Gerodetti <jovan.gerodetti@titannano.de>
jryans
approved these changes
Jun 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed the requested changes from #3991.